[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9982: feat: implement secondary navigation for datasets

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#discussion_r435409848



##########
File path: superset-frontend/src/components/Menu/Menu.less
##########
@@ -39,3 +43,42 @@
     }
   }
 }
+
+#secondary-menu {
+  margin-top: -20px;
+  .navbar-header .navbar-brand {
+    font-weight: @font-weight-bold;
+  }
+  .navbar-right {
+    .btn-default {
+      text-transform: uppercase;
+      font-weight: 500;
+      font-size: @font-size-s;
+      background-color: @brand-primary;
+      border-radius: 4px;
+      color: @lightest;
+      margin: 8px 43px;
+      padding: 8px 51px 8px 43px;
+      border: none;
+      i {
+        padding: 4px @font-size-xs;
+      }
+    }
+  }
+  .navbar-nav {
+    li {
+      a {
+        font-size: @font-size-s;
+        padding: 8px;
+        margin: 8px;
+        color: #3d3d3d;

Review comment:
       Should this be a color variable?

##########
File path: superset-frontend/src/components/Menu/Menu.less
##########
@@ -39,3 +43,42 @@
     }
   }
 }
+
+#secondary-menu {
+  margin-top: -20px;
+  .navbar-header .navbar-brand {
+    font-weight: @font-weight-bold;
+  }
+  .navbar-right {
+    .btn-default {
+      text-transform: uppercase;
+      font-weight: 500;
+      font-size: @font-size-s;
+      background-color: @brand-primary;
+      border-radius: 4px;
+      color: @lightest;
+      margin: 8px 43px;
+      padding: 8px 51px 8px 43px;
+      border: none;
+      i {
+        padding: 4px @font-size-xs;
+      }
+    }
+  }
+  .navbar-nav {
+    li {
+      a {
+        font-size: @font-size-s;
+        padding: 8px;
+        margin: 8px;
+        color: #3d3d3d;
+      }
+    }
+    li.active > a,
+    li > a:hover {
+      background: #eceef2;

Review comment:
       Same question - should this be a variable?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org