You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/14 02:20:16 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new issue #10307: api/v1/dashboard API response time format is wrong
graceguo-supercat opened a new issue #10307:
URL: https://github.com/apache/incubator-superset/issues/10307
I found the time format for `welcome` page is messaged up.
in welcome front-end js use `moment` to parse time string. for example if i crated a dashboard at 2020-07-13T19:09:54.991076 PSD time, API responded as `changed_on: "2020-07-13T19:09:54.991076+00:00"`.
Compare the welcome page vs dashboard list view:
### Expected results
<img width="959" alt="Screen Shot 2020-07-13 at 7 10 41 PM" src="https://user-images.githubusercontent.com/27990562/87372660-fb1e5480-c53c-11ea-9a09-291ac0e324f2.png">
### Actual results
<img width="943" alt="Screen Shot 2020-07-13 at 7 10 30 PM" src="https://user-images.githubusercontent.com/27990562/87372644-f3f74680-c53c-11ea-8958-1a9d70c20935.png">
### Environment
(please complete the following information):
latest master branch
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
@dpgaspar @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #10307: api/v1/dashboard API response time format is wrong
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #10307:
URL: https://github.com/apache/incubator-superset/issues/10307#issuecomment-658921106
fixed on master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #10307: api/v1/dashboard API response time format is wrong
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #10307:
URL: https://github.com/apache/incubator-superset/issues/10307#issuecomment-658286272
This is an interesting problem, actually on marshmallow 2 the response from the API is correct: `changed_on: "2020-07-13T19:09:54.991076+00:00"` if your metadata database is configured for UTC and your web server.
I actually just found a problem with marshmallow 3 upgrade, since it will not add the UTC timezone to naive datetime, and it seems that is what superset is saving. I have a fix for that, but need more info, it seems that your web server is on PSD is that correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #10307: api/v1/dashboard API response time format is wrong
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #10307:
URL: https://github.com/apache/incubator-superset/issues/10307#issuecomment-657935529
we're using moment.js on the frontend to format the timestamp, so that might be the issue (if the data doesn't include timezone).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar closed issue #10307: api/v1/dashboard API response time format is wrong
Posted by GitBox <gi...@apache.org>.
dpgaspar closed issue #10307:
URL: https://github.com/apache/incubator-superset/issues/10307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on issue #10307: api/v1/dashboard API response time format is wrong
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #10307:
URL: https://github.com/apache/incubator-superset/issues/10307#issuecomment-658288746
> This is an interesting problem, actually on marshmallow 2 the response from the API is correct: `changed_on: "2020-07-13T19:09:54.991076+00:00"` if your metadata database is configured for UTC and your web server.
>
> I actually just found a problem with marshmallow 3 upgrade, since it will not add the UTC timezone to naive datetime, and it seems that is what superset is saving. I have a fix for that, but need more info, it seems that your web server is on PSD is that correct?
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #10307: api/v1/dashboard API response time format is wrong
Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #10307:
URL: https://github.com/apache/incubator-superset/issues/10307#issuecomment-658339636
@graceguo-supercat, @dpgaspar: our webserver and metadata databases are on UTC, not Pacific Time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #10307: api/v1/dashboard API response time format is wrong
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #10307:
URL: https://github.com/apache/incubator-superset/issues/10307#issuecomment-658397153
@etr2460 ok but the above example makes sense on a Pacific Time server. Yet we got a problem here, I'll make a PR tomorrow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #10307: api/v1/dashboard API response time format is wrong
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #10307:
URL: https://github.com/apache/incubator-superset/issues/10307#issuecomment-658042339
Thanks @graceguo-supercat , I'll flag this for 0.37.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10307: api/v1/dashboard API response time format is wrong
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10307:
URL: https://github.com/apache/incubator-superset/issues/10307#issuecomment-657926604
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.94. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org