You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/16 17:56:00 UTC
[jira] [Work logged] (GOBBLIN-1120) Reinitialize HelixManager when
Helix participant check throws an exception
[ https://issues.apache.org/jira/browse/GOBBLIN-1120?focusedWorklogId=423615&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-423615 ]
ASF GitHub Bot logged work on GOBBLIN-1120:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/20 17:55
Start Date: 16/Apr/20 17:55
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2960: GOBBLIN-1120: Reinitialize HelixManager when Helix participant check …
URL: https://github.com/apache/incubator-gobblin/pull/2960
…throws an exception
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1120
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
When the underlying ZkClient is closed, Helix participant check throws:
Caused by: java.lang.IllegalStateException: ZkClient already closed!
In these cases, the HelixManager instance used to do the participant check needs to be re-initialized to obtain a new ZKClient.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Enhanced the unit tests in HelixAssignedParticipantCheckTest.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 423615)
Remaining Estimate: 0h
Time Spent: 10m
> Reinitialize HelixManager when Helix participant check throws an exception
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1120
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1120
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When the underlying ZkClient is closed, Helix participant check throws:
> Caused by: java.lang.IllegalStateException: ZkClient already closed!
> In these cases, the HelixManager instance used to do the participant check needs to be re-initialized to obtain a new ZKClient.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)