[GitHub] [beam] mprashanthsagar commented on a change in pull request #14817: [BEAM-8889] Upgrade GCSIO to 2.2.2

[GitBox <gi...@apache.org>]

mprashanthsagar commented on a change in pull request #14817:
URL: https://github.com/apache/beam/pull/14817#discussion_r662169853



##########
File path: sdks/java/extensions/google-cloud-platform-core/src/test/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilTest.java
##########
@@ -772,7 +773,11 @@ public void testGCSChannelCloseIdempotent() throws IOException {
         GoogleCloudStorageReadOptions.builder().setFastFailOnNotFound(false).build();
     SeekableByteChannel channel =
         new GoogleCloudStorageReadChannel(
-            null, "dummybucket", "dummyobject", null, new ClientRequestHelper<>(), readOptions);
+            null,
+            new StorageResourceId("dummybucket", "dummyobject"),

Review comment:
       can we maintain `testBucket` and `testObject` for consistency ?

##########
File path: sdks/java/extensions/google-cloud-platform-core/src/test/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilTest.java
##########
@@ -772,7 +773,11 @@ public void testGCSChannelCloseIdempotent() throws IOException {
         GoogleCloudStorageReadOptions.builder().setFastFailOnNotFound(false).build();
     SeekableByteChannel channel =
         new GoogleCloudStorageReadChannel(

Review comment:
       nit : We could remove the dependency on `GoogleCloudStorageReadChannel` and use the higher level of abstraction of `GCSImpl`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org