[GitHub] [hudi] pengzhiwei2018 edited a comment on pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

[GitBox <gi...@apache.org>]

pengzhiwei2018 edited a comment on pull request #2645:
URL: https://github.com/apache/hudi/pull/2645#issuecomment-833195752


   > @pengzhiwei2018 few suggestions/questions . could you please clarify?
   > 
   > * How does one pass any `HoodieWriteConfig` for a INSERT/UPDATE/DELETE/MERGE statement
   > * Setting user specified metadata with each commit. This is very important for interplay with deltastreamer etc.
   > * Do we support setting table properties? SET command.
   > * Can we add a functional test that does a sequence of statements and parameterize it for both COW/MOR? Want to ensure we can document the entire support matrix.
   > * Should we add more rigorous tests for  partitioned tables/data types?
   > 
   > Next steps for me is to run it at a larger scale on a cluster.
   
   
   Hi @vinothchandar 
   > How does one pass any `HoodieWriteConfig` for a INSERT/UPDATE/DELETE/MERGE statement
   
   Using the set options. e.g. `set hoodie.insert.shuffle.parallelism = 4`
   
   > Do we support setting table properties? SET command.
   Yes, we support SET Command to set the write config and other runtime properties. For table properties like table type, table name, we can use the alter table command. 
   
   > Can we add a functional test that does a sequence of statements and parameterize it for both COW/MOR? Want to ensure we can document the entire support matrix.
   
   Yes, that is great. I will do this.
   
   > Should we add more rigorous tests for partitioned tables/data types?
   
   Of course, I will add more test case to cover more data types.
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org