You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "Michael Brohl (Jira)" <ji...@apache.org> on 2021/02/01 16:46:00 UTC

[jira] [Closed] (OFBIZ-11385) Possible NPE in DatabaseUtil.getColumnInfo(...)

     [ https://issues.apache.org/jira/browse/OFBIZ-11385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Brohl closed OFBIZ-11385.
---------------------------------
    Fix Version/s: 18.12.01
       Resolution: Fixed

Manually backported to 18.12. Thanks Benjamin.

> Possible NPE in DatabaseUtil.getColumnInfo(...)
> -----------------------------------------------
>
>                 Key: OFBIZ-11385
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11385
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/webtools
>    Affects Versions: Trunk
>            Reporter: Benjamin Jugl
>            Assignee: Michael Brohl
>            Priority: Major
>             Fix For: 18.12.01, Upcoming Branch
>
>         Attachments: OFBIZ-11385_Possible_NPE_in_DatabaseUtil_001.patch
>
>
> Right at the start DatabaseUtil.getColumnInfo(....) does an if comparison to 0 with the unchecked parameter tableNames.
> The way this method and especially the parameter is used in DatabaseUtil.induceModelFromDb(Collection<String> messages) is not secure to not provide null-values for this parameter.
> I suggest using a UtilValidate.isEmpty(...) instead of the unsave comparison.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)