You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/10 06:57:55 UTC
[GitHub] [flink] wangyang0918 commented on a change in pull request #10496:
[FLINK-15153]Service selector needs to contain jobmanager component label
wangyang0918 commented on a change in pull request #10496: [FLINK-15153]Service selector needs to contain jobmanager component label
URL: https://github.com/apache/flink/pull/10496#discussion_r355869102
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -108,17 +101,31 @@ public String getClusterDescription() {
@Override
public ClusterClientProvider<String> retrieve(String clusterId) {
- return createClusterClientProvider(clusterId);
+ final ClusterClientProvider<String> clusterClientProvider = createClusterClientProvider(clusterId);
+
+ try (ClusterClient<String> clusterClient = clusterClientProvider.getClusterClient()) {
Review comment:
We do not change any behavior here. We just get the real cluster client of `ClusterClientProvider` for logging and then close it. The `ClusterClientProvider` do not need to be close, the `ClusterClientProvider.getClusterClient()` should do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services