[GitHub] [gobblin] rdsr commented on a diff in pull request #3696: [GOBBLIN-1833]Emit Completeness watermark information in snapshotCommitEvent

["rdsr (via GitHub)" <gi...@apache.org>]

rdsr commented on code in PR #3696:
URL: https://github.com/apache/gobblin/pull/3696#discussion_r1199634038


##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java:
##########
@@ -1011,6 +1011,9 @@ private void submitSnapshotCommitEvent(Snapshot snapshot, TableMetadata tableMet
         gobblinTrackingEvent.addMetadata(entry.getKey(), entry.getValue());
       }
     }
+    if (tableMetadata.completenessEnabled) {

Review Comment:
   Do we now have to enable this feature on every table?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org