[GitHub] [samza] bringhurst commented on a change in pull request #1523: SAMZA-2676: Pass parameter into subset, not format (StreamConfig.getSerdeStreams)

[GitBox <gi...@apache.org>]

bringhurst commented on a change in pull request #1523:
URL: https://github.com/apache/samza/pull/1523#discussion_r696121203



##########
File path: samza-core/src/main/java/org/apache/samza/config/StreamConfig.java
##########
@@ -278,7 +278,7 @@ public SystemStream streamIdToSystemStream(String streamId) {
    * Returns a list of all SystemStreams that have a serde defined from the config file.
    */
   public Set<SystemStream> getSerdeStreams(String systemName) {
-    Config subConf = subset(String.format("systems.%s.streams.", systemName, true));
+    Config subConf = subset(String.format("systems.%s.streams.", systemName));

Review comment:
       Changed to pass into subset after slack discussion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org