You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/11 03:11:39 UTC

[GitHub] [flink] xintongsong commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible

xintongsong commented on issue #10829: [FLINK-14853][docs] Use higher granularity units in generated docs for Duration & MemorySize if possible
URL: https://github.com/apache/flink/pull/10829#issuecomment-573274699
 
 
   Thanks for pointing me to this, @zentol.
   
   Hi @dawidwys, thanks for the PR.
   
   I agree it would be nice to have higher granularity unit in the docs. However, `MemorySize#toString` does not only affect the docs, but also logs.
   
   There are cases that memory sizes are derived from a total size and a fraction (e.g. managed memory). In those cases, a memory size could be large but not integer with high granularity units. Therefore, I think it would make sense to print both the exact bytes for accuracy and the coarse high granularity value for readability (as in #10785).
   
   WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services