You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Philippe Mouawad (JIRA)" <ji...@apache.org> on 2009/05/29 19:53:50 UTC

[jira] Created: (AMQ-2274) Setting keepAlive through URL does nothing

Setting keepAlive through URL does nothing
------------------------------------------

                 Key: AMQ-2274
                 URL: https://issues.apache.org/activemq/browse/AMQ-2274
             Project: ActiveMQ
          Issue Type: Bug
    Affects Versions: 5.2.0, 5.1.0
         Environment: jdk5 
            Reporter: Philippe Mouawad
            Priority: Critical


I use ActiveMQ 5.2 and configure a client using jndi.properties with connection url:
connection.TopicConnectionFactory.brokerURL=tcp://localhost:61616?soTimeout=30000&connectionTimeout=30000&keepAlive=true&minmumWireFormatVersion=3&jms.prefetchPolicy.all=5


All boolean properties (keepAlive) are ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2274) Setting keepAlive through URL does nothing

Posted by "Will Tran (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52903#action_52903 ] 

Will Tran commented on AMQ-2274:
--------------------------------

If you're using Phillipe's workaround, you still may need to register the BooleanEditor with java.beans.PropertyEditorManager, as PropertyEditorManager.findEditor(Boolean.class) (which is used in IntrospectionUtils) still returned null with the BooleanEditor in the classpath. I did that in some bootstrap code with this line:

PropertyEditorManager.registerEditor(Boolean.class, BooleanEditor.class);

> Setting keepAlive through URL does nothing
> ------------------------------------------
>
>                 Key: AMQ-2274
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2274
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.1.0, 5.2.0
>         Environment: jdk5 
>            Reporter: Philippe Mouawad
>            Assignee: Gary Tully
>            Priority: Critical
>             Fix For: 5.3.0
>
>         Attachments: BooleanEditor.java, BugKeepAlive.java
>
>
> I use ActiveMQ 5.2 and configure a client using jndi.properties with connection url:
> connection.TopicConnectionFactory.brokerURL=tcp://localhost:61616?soTimeout=30000&connectionTimeout=30000&keepAlive=true&minmumWireFormatVersion=3&jms.prefetchPolicy.all=5
> All boolean properties (keepAlive) are ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2274) Setting keepAlive through URL does nothing

Posted by "Philippe Mouawad (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51986#action_51986 ] 

Philippe Mouawad commented on AMQ-2274:
---------------------------------------

I looked at code of 5.2 and the bug seems to come from IntrospectionSupport.setProperty, look at attached file to see that Boolean conversion fails.


I checked out trunk version of IntrospectionSupport and it seems that code has drastically changed and registers Spring property editor for Boolean.
But looking at RoadMap I didn't see any comment about that bug, so I register it just to see it in changelog


Philippe
www.ubik-ingenierie.com

> Setting keepAlive through URL does nothing
> ------------------------------------------
>
>                 Key: AMQ-2274
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2274
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.1.0, 5.2.0
>         Environment: jdk5 
>            Reporter: Philippe Mouawad
>            Priority: Critical
>         Attachments: BugKeepAlive.java
>
>
> I use ActiveMQ 5.2 and configure a client using jndi.properties with connection url:
> connection.TopicConnectionFactory.brokerURL=tcp://localhost:61616?soTimeout=30000&connectionTimeout=30000&keepAlive=true&minmumWireFormatVersion=3&jms.prefetchPolicy.all=5
> All boolean properties (keepAlive) are ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-2274) Setting keepAlive through URL does nothing

Posted by "Philippe Mouawad (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philippe Mouawad updated AMQ-2274:
----------------------------------

    Attachment: BooleanEditor.java

BooleanEditor

> Setting keepAlive through URL does nothing
> ------------------------------------------
>
>                 Key: AMQ-2274
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2274
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.1.0, 5.2.0
>         Environment: jdk5 
>            Reporter: Philippe Mouawad
>            Priority: Critical
>         Attachments: BooleanEditor.java, BugKeepAlive.java
>
>
> I use ActiveMQ 5.2 and configure a client using jndi.properties with connection url:
> connection.TopicConnectionFactory.brokerURL=tcp://localhost:61616?soTimeout=30000&connectionTimeout=30000&keepAlive=true&minmumWireFormatVersion=3&jms.prefetchPolicy.all=5
> All boolean properties (keepAlive) are ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2274) Setting keepAlive through URL does nothing

Posted by "Philippe Mouawad (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51987#action_51987 ] 

Philippe Mouawad commented on AMQ-2274:
---------------------------------------

I looked in more detail the trunk code it will still fails even with Spring property editors since the class is CustomBoolean.
I attach a class to solve this issue but this introduces a dependency on Spring (although it seems this dependency is already here)

> Setting keepAlive through URL does nothing
> ------------------------------------------
>
>                 Key: AMQ-2274
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2274
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.1.0, 5.2.0
>         Environment: jdk5 
>            Reporter: Philippe Mouawad
>            Priority: Critical
>         Attachments: BooleanEditor.java, BugKeepAlive.java
>
>
> I use ActiveMQ 5.2 and configure a client using jndi.properties with connection url:
> connection.TopicConnectionFactory.brokerURL=tcp://localhost:61616?soTimeout=30000&connectionTimeout=30000&keepAlive=true&minmumWireFormatVersion=3&jms.prefetchPolicy.all=5
> All boolean properties (keepAlive) are ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-2274) Setting keepAlive through URL does nothing

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully resolved AMQ-2274.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 5.3.0

included Boolean test and added implementation of BooleanEditor that extends java.beans.PropertyEditorSupport rather than spring class.

r783281

> Setting keepAlive through URL does nothing
> ------------------------------------------
>
>                 Key: AMQ-2274
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2274
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.1.0, 5.2.0
>         Environment: jdk5 
>            Reporter: Philippe Mouawad
>            Assignee: Gary Tully
>            Priority: Critical
>             Fix For: 5.3.0
>
>         Attachments: BooleanEditor.java, BugKeepAlive.java
>
>
> I use ActiveMQ 5.2 and configure a client using jndi.properties with connection url:
> connection.TopicConnectionFactory.brokerURL=tcp://localhost:61616?soTimeout=30000&connectionTimeout=30000&keepAlive=true&minmumWireFormatVersion=3&jms.prefetchPolicy.all=5
> All boolean properties (keepAlive) are ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (AMQ-2274) Setting keepAlive through URL does nothing

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully reassigned AMQ-2274:
-------------------------------

    Assignee: Gary Tully

> Setting keepAlive through URL does nothing
> ------------------------------------------
>
>                 Key: AMQ-2274
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2274
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.1.0, 5.2.0
>         Environment: jdk5 
>            Reporter: Philippe Mouawad
>            Assignee: Gary Tully
>            Priority: Critical
>         Attachments: BooleanEditor.java, BugKeepAlive.java
>
>
> I use ActiveMQ 5.2 and configure a client using jndi.properties with connection url:
> connection.TopicConnectionFactory.brokerURL=tcp://localhost:61616?soTimeout=30000&connectionTimeout=30000&keepAlive=true&minmumWireFormatVersion=3&jms.prefetchPolicy.all=5
> All boolean properties (keepAlive) are ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-2274) Setting keepAlive through URL does nothing

Posted by "Philippe Mouawad (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philippe Mouawad updated AMQ-2274:
----------------------------------

    Attachment: BugKeepAlive.java

Class that illustrates the bug in IntrospectionSupport.setProperty

> Setting keepAlive through URL does nothing
> ------------------------------------------
>
>                 Key: AMQ-2274
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2274
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.1.0, 5.2.0
>         Environment: jdk5 
>            Reporter: Philippe Mouawad
>            Priority: Critical
>         Attachments: BugKeepAlive.java
>
>
> I use ActiveMQ 5.2 and configure a client using jndi.properties with connection url:
> connection.TopicConnectionFactory.brokerURL=tcp://localhost:61616?soTimeout=30000&connectionTimeout=30000&keepAlive=true&minmumWireFormatVersion=3&jms.prefetchPolicy.all=5
> All boolean properties (keepAlive) are ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.