You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/03 09:52:47 UTC
[GitHub] [cloudstack] Spaceman1984 opened a new pull request #3924: Fixed
error on data volumes lager than 2.2TB when creating instances on VMware
Spaceman1984 opened a new pull request #3924: Fixed error on data volumes lager than 2.2TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924
## Description
<!--- Describe your changes in detail -->
This PR fixes an issue where creating instances with data volumes greater than 2.147TB on VMWare fails. This is due to an overflow error when megabytes are converted to kilobytes.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
To reproduce:
Try to create an instance with a custom data volume size greater than 2200 MB using a VMWare hypervisor.
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
This was tested by creating a data volume greater than 2.2T from the UI using the add instance wizard.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3924: Fixed error on
data volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-594631447
<b>Trillian test result (tid-1181)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31627 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3924-t1181-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 75 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 254.03 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 261.98 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 392.62 | test_privategw_acl.py
test_05_stop_ssvm | `Failure` | 41.41 | test_ssvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3924: Fixed error on
data volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-595301769
<b>Trillian test result (tid-1192)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31518 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3924-t1192-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 262.03 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 264.56 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 401.04 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Spaceman1984 commented on issue #3924: Fixed error on
data volumes lager than 2.2TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #3924: Fixed error on data volumes lager than 2.2TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-593862767
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3924: Fixed error on
data volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-595056968
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3924: Fixed error on data
volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-595056881
sometimes 2nd time's a charm
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3924: Fixed error on data
volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-594358326
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3924: Fixed error on
data volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-593871807
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-988
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3924: Fixed error on
data volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3924: Fixed error
on data volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-595165850
@DaanHoogland regression tests not yet done..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3924: Fixed error on
data volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-594358418
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3924: Fixed error on
data volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-593863155
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3924: Fixed error
on data volumes lager than 2.14TB when creating instances on VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3924: Fixed error on data volumes lager than 2.14TB when creating instances on VMware
URL: https://github.com/apache/cloudstack/pull/3924#issuecomment-595163769
Tested with fixed and custom offerings, with 3300/3500GB - all good, and visible inside VM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services