You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/06/12 08:05:42 UTC

[GitHub] [doris] morningman opened a new pull request, #20704: [fix](routine-load) fix stackoverflow bug in routine load

morningman opened a new pull request, #20704:
URL: https://github.com/apache/doris/pull/20704

   ## Proposed changes
   
   When executing routine load job, there may encounter StackOverflowException.
   This is because the expr in column setting list will be analyze for each routine load sub task,
   and there is a self-reference bug that may cause endless loop when analyzing expr.
   
   The following columns expr list may trigger this bug:
   
   ```
   columns(col1, col2,
   col2=null_or_empty(col2),
   col1=null_or_empty(col2))
   ```
   
   This fix is verified by user, but I can't add regression test for this case, because I can't submit a routine load job
   in our regression test, and this bug can only be triggered in routine load.
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman merged pull request #20704: [fix](routine-load) fix stackoverflow bug in routine load

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #20704:
URL: https://github.com/apache/doris/pull/20704


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20704: [fix](routine-load) fix stackoverflow bug in routine load

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20704:
URL: https://github.com/apache/doris/pull/20704#issuecomment-1586911628

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #20704: [fix](routine-load) fix stackoverflow bug in routine load

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #20704:
URL: https://github.com/apache/doris/pull/20704#issuecomment-1586829299

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #20704: [fix](routine-load) fix stackoverflow bug in routine load

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20704:
URL: https://github.com/apache/doris/pull/20704#issuecomment-1586911773

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org