You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/03/28 02:10:41 UTC

Review Request 70329: Added `==` and `!=` operator in `ResourceQuantities`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70329/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Added `==` and `!=` operator in `ResourceQuantities`.


Diffs
-----

  src/common/resource_quantities.hpp db4f5afb9f617e27bd08756020b4bcf0bd92dc66 
  src/common/resource_quantities.cpp 9ae5d9f4aefde81cde7463a7ce118c65a68fc0db 


Diff: https://reviews.apache.org/r/70329/diff/1/


Testing
-------

make check
Also tested in r/70330


Thanks,

Meng Zhu


Re: Review Request 70329: Added `==` and `!=` operator in `ResourceQuantities`.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70329/#review214186
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On March 28, 2019, 2:10 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70329/
> -----------------------------------------------------------
> 
> (Updated March 28, 2019, 2:10 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `==` and `!=` operator in `ResourceQuantities`.
> 
> 
> Diffs
> -----
> 
>   src/common/resource_quantities.hpp db4f5afb9f617e27bd08756020b4bcf0bd92dc66 
>   src/common/resource_quantities.cpp 9ae5d9f4aefde81cde7463a7ce118c65a68fc0db 
> 
> 
> Diff: https://reviews.apache.org/r/70329/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> Also tested in r/70330
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>