You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/08 06:34:37 UTC

[GitHub] [arrow] mqy opened a new pull request #9133: ARROW-11168: [Rust] Fix cargo doc warnings

mqy opened a new pull request #9133:
URL: https://github.com/apache/arrow/pull/9133


   The files in ipc/gen were updated too. I had filed an issue https://issues.apache.org/jira/browse/ARROW-11179 to address this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] alamb commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756951455


   This PR probably needs to be rebased to pick up the fix for https://github.com/apache/arrow/pull/9138 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756760161


   The build failed, no idea why does it build `parquet-format 2.7.0`.
   I filed the problem at https://issues.apache.org/jira/browse/ARROW-11184
   @nevi-me I saw you just released parquet-format 2.7.0 hours ago, any idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756760161


   The build failed, no idea why does it build `parquet-format 2.7.0`.
   I can't reproduce this problem with `cargo build --all-targets` on my local host with PR
   
   The problem is filed at https://issues.apache.org/jira/browse/ARROW-11184
   
   @nevi-me I saw you just released parquet-format 2.7.0 hours ago, any idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] alamb commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756821495


   As pointed out by @carols10cents , this appears to have failed on master too: https://github.com/apache/arrow/actions?query=branch%3Amaster+workflow%3ARust
   
   https://github.com/apache/arrow/actions/runs/471629105
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756805692


   We released `parquet-format-rs:2.7.0` today. If it's breaking this build, then it's likely going to break others. I'll have a look, and pin versions if needed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] alamb closed pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9133:
URL: https://github.com/apache/arrow/pull/9133


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756760161


   The build failed, no idea why does it build `parquet-format 2.7.0`.
   I can't reproduce this problem with `cargo build --all-targets` on my local host with PR
   
   The merged PR https://github.com/apache/arrow/commit/c4ee53626f975f9c005cbef234552f8fe457d0dc also failed with same error.
   
   The problem is filed at https://issues.apache.org/jira/browse/ARROW-11184
   
   @nevi-me  I saw you just released parquet-format 2.7.0 hours ago, any idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] alamb commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-757134626


   FWIW I tested this branch out locally and it worked really nicely -- no more warnings during build. Thanks @mqy !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756615098


   Turn to draft because there are cargo test errors. Back soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756760161






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756975918


   > LGTM. Thanks a lot for taking this!
   
   @jorgecarleitao thanks for the review. It seems the CI is getting close to success, please review again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9133: ARROW-11168: [Rust] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756578426


   https://issues.apache.org/jira/browse/ARROW-11168


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756760161


   The build failed, no idea why it build `parquet-format 2.7.0`.
   I filed the problem at https://issues.apache.org/jira/browse/ARROW-11184


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756760161


   The build failed, no idea why does it build `parquet-format 2.7.0`.
   I filed the problem at https://issues.apache.org/jira/browse/ARROW-11184


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756760161


   The build failed, no idea why does it build `parquet-format 2.7.0`.
   I filed the problem at https://issues.apache.org/jira/browse/ARROW-11184 @nevi-me 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] alamb commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756821495






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756760161


   The build failed, no idea why does it build `parquet-format 2.7.0`.
   I can't reproduce this problem with `cargo build --all-targets` on my local host with PR
   
   The merged commit https://github.com/apache/arrow/commit/c4ee53626f975f9c005cbef234552f8fe457d0dc also failed with same error.
   
   The problem is filed at https://issues.apache.org/jira/browse/ARROW-11184
   
   @nevi-me  I saw you just released parquet-format 2.7.0 hours ago, any idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756760161


   The build failed, no idea why does it build `parquet-format 2.7.0`.
   I can't reproduce this problem with `cargo build --all-targets` on my local host with code of this PR.
   
   The merged commit https://github.com/apache/arrow/commit/c4ee53626f975f9c005cbef234552f8fe457d0dc also failed with same error.
   
   The problem is filed at https://issues.apache.org/jira/browse/ARROW-11184
   
   @nevi-me  I saw you just released parquet-format 2.7.0 hours ago, any idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756825835


   @alamb I've opened #9138 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756760161


   The build failed, no idea why does it build `parquet-format 2.7.0`.
   I can't reproduce this problem with `cargo build --all-targets` on my local host with PR
   
   The problem is filed at https://issues.apache.org/jira/browse/ARROW-11184
   
   @nevi-me  I saw you just released parquet-format 2.7.0 hours ago, any idea?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756615098






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756805692






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] alamb commented on pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9133:
URL: https://github.com/apache/arrow/pull/9133#issuecomment-756822608


   I'll look into this and try and get the build passing again


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] alamb closed pull request #9133: ARROW-11168: [Rust] [Doc] Fix cargo doc warnings

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9133:
URL: https://github.com/apache/arrow/pull/9133


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org