You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Dennis Kieselhorst <de...@apache.org> on 2023/06/14 05:15:41 UTC
Re: Re: Release Commons Fileupload 1.4.1?
Hi Gary,
successfully tested the latest SNAPSHOT with the new module structure yesterday. Please release it.
Thanks,
Dennis
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: Re: Release Commons Fileupload 1.4.1?
Posted by Gary Gregory <ga...@gmail.com>.
We are not ready but are working diligently towards a 2.0.0-M1 release,
probably within the next month or so.
Gary
On Wed, Jun 14, 2023, 01:15 Dennis Kieselhorst <de...@apache.org> wrote:
> Hi Gary,
>
> successfully tested the latest SNAPSHOT with the new module structure
> yesterday. Please release it.
>
> Thanks,
> Dennis
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?
Posted by Gary Gregory <ga...@gmail.com>.
There are no blockers, just life, I'll try to get to it this week.
Gary
On Tue, Jul 4, 2023, 00:54 Dennis Kieselhorst <de...@apache.org> wrote:
> Hi Gary,
>
> what's blocking the 2.0.0-M1 release? Can I help implementing it?
>
> Best,
> Dennis
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?
Posted by Dennis Kieselhorst <de...@apache.org>.
Hi Gary,
what's blocking the 2.0.0-M1 release? Can I help implementing it?
Best,
Dennis
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?
Posted by Maxim Solodovnik <so...@gmail.com>.
On Wed, 14 Jun 2023 at 22:39, Gary Gregory <ga...@gmail.com> wrote:
>
> Let me take a look at this, but you should really be using a file item
> factory to create file items...
Thanks a million!
Here is the original code:
https://github.com/apache/wicket/blob/wicket-9.x/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletPartFileItem.java#L189
Here is the branch with latest commons-fileupload2:
https://github.com/apache/wicket/blob/commons-fileupload2-back/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/ServletPartFileItem.java#L190
Maybe the code need to be refactored to use Factory ...
I'll try to take a look :) (most probably after vacation ... :))
>
> Gary
>
> On Wed, Jun 14, 2023, 09:06 Maxim Solodovnik <so...@gmail.com> wrote:
>
> > On Wed, 14 Jun 2023 at 19:46, Gary Gregory <ga...@gmail.com> wrote:
> > >
> > > A FileItemHeadersImpl is created by calling
> > > AbstractFileUpload#newFileItemHeaders()
> >
> > At Apache Wicket we are implementing FileItem and need a way to create
> > FileItemHeaders
> > AbstractFileUpload#newFileItemHeaders() is not static :(((
> >
> > >
> > > Gary
> > >
> > > On Wed, Jun 14, 2023, 06:50 Maxim Solodovnik <so...@gmail.com>
> > wrote:
> > >
> > > > It seems I have API related question:
> > > >
> > > > FileItemHeadersImpl is not public anymore :((
> > > > How it can be created? :)))
> > > >
> > > > On Wed, 14 Jun 2023 at 17:28, Maxim Solodovnik <so...@gmail.com>
> > > > wrote:
> > > > >
> > > > > It seems new jar file missing `Automatic-Module-Name` would it be
> > > > > possible to add it? :)
> > > > >
> > > > > On Wed, 14 Jun 2023 at 17:10, Maxim Solodovnik <solomax666@gmail.com
> > >
> > > > wrote:
> > > > > >
> > > > > > On Wed, 14 Jun 2023 at 16:53, Gary Gregory <garydgregory@gmail.com
> > >
> > > > wrote:
> > > > > > >
> > > > > > > Glad to hear that your testing went well.
> > > > > > >
> > > > > > > Some of the documentation needs to be rewritten, so I'll look at
> > > > that next
> > > > > > > unless someone else gets to it first.
> > > > > > >
> > > > > > > I plan on creating a release candidate for a 2.0.0-beta1 or
> > 2.0.0-M1
> > > > within
> > > > > > > a week or so.
> > > > > >
> > > > > > Great news :)
> > > > > >
> > > > > > > Since this is a major release I think it is important to make
> > > > > > > at least one version available before 2.0.0 sets the API in
> > stone for
> > > > > > > binary compatibility.
> > > > > >
> > > > > > M1 sounds very reasonable :)
> > > > > >
> > > > > > >
> > > > > > > Gary
> > > > > > >
> > > > > > > On Wed, Jun 14, 2023, 01:15 Dennis Kieselhorst <de...@apache.org>
> > > > wrote:
> > > > > > >
> > > > > > > > Hi Gary,
> > > > > > > >
> > > > > > > > successfully tested the latest SNAPSHOT with the new module
> > > > structure
> > > > > > > > yesterday. Please release it.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Dennis
> > > > > > > >
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > > > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > > > > > >
> > > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Best regards,
> > > > > > Maxim
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Best regards,
> > > > > Maxim
> > > >
> > > >
> > > >
> > > > --
> > > > Best regards,
> > > > Maxim
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > >
> > > >
> >
> >
> >
> > --
> > Best regards,
> > Maxim
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
--
Best regards,
Maxim
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?
Posted by Gary Gregory <ga...@gmail.com>.
Let me take a look at this, but you should really be using a file item
factory to create file items...
Gary
On Wed, Jun 14, 2023, 09:06 Maxim Solodovnik <so...@gmail.com> wrote:
> On Wed, 14 Jun 2023 at 19:46, Gary Gregory <ga...@gmail.com> wrote:
> >
> > A FileItemHeadersImpl is created by calling
> > AbstractFileUpload#newFileItemHeaders()
>
> At Apache Wicket we are implementing FileItem and need a way to create
> FileItemHeaders
> AbstractFileUpload#newFileItemHeaders() is not static :(((
>
> >
> > Gary
> >
> > On Wed, Jun 14, 2023, 06:50 Maxim Solodovnik <so...@gmail.com>
> wrote:
> >
> > > It seems I have API related question:
> > >
> > > FileItemHeadersImpl is not public anymore :((
> > > How it can be created? :)))
> > >
> > > On Wed, 14 Jun 2023 at 17:28, Maxim Solodovnik <so...@gmail.com>
> > > wrote:
> > > >
> > > > It seems new jar file missing `Automatic-Module-Name` would it be
> > > > possible to add it? :)
> > > >
> > > > On Wed, 14 Jun 2023 at 17:10, Maxim Solodovnik <solomax666@gmail.com
> >
> > > wrote:
> > > > >
> > > > > On Wed, 14 Jun 2023 at 16:53, Gary Gregory <garydgregory@gmail.com
> >
> > > wrote:
> > > > > >
> > > > > > Glad to hear that your testing went well.
> > > > > >
> > > > > > Some of the documentation needs to be rewritten, so I'll look at
> > > that next
> > > > > > unless someone else gets to it first.
> > > > > >
> > > > > > I plan on creating a release candidate for a 2.0.0-beta1 or
> 2.0.0-M1
> > > within
> > > > > > a week or so.
> > > > >
> > > > > Great news :)
> > > > >
> > > > > > Since this is a major release I think it is important to make
> > > > > > at least one version available before 2.0.0 sets the API in
> stone for
> > > > > > binary compatibility.
> > > > >
> > > > > M1 sounds very reasonable :)
> > > > >
> > > > > >
> > > > > > Gary
> > > > > >
> > > > > > On Wed, Jun 14, 2023, 01:15 Dennis Kieselhorst <de...@apache.org>
> > > wrote:
> > > > > >
> > > > > > > Hi Gary,
> > > > > > >
> > > > > > > successfully tested the latest SNAPSHOT with the new module
> > > structure
> > > > > > > yesterday. Please release it.
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Dennis
> > > > > > >
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > > > > >
> > > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Best regards,
> > > > > Maxim
> > > >
> > > >
> > > >
> > > > --
> > > > Best regards,
> > > > Maxim
> > >
> > >
> > >
> > > --
> > > Best regards,
> > > Maxim
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> > >
>
>
>
> --
> Best regards,
> Maxim
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?
Posted by Maxim Solodovnik <so...@gmail.com>.
On Wed, 14 Jun 2023 at 19:46, Gary Gregory <ga...@gmail.com> wrote:
>
> A FileItemHeadersImpl is created by calling
> AbstractFileUpload#newFileItemHeaders()
At Apache Wicket we are implementing FileItem and need a way to create
FileItemHeaders
AbstractFileUpload#newFileItemHeaders() is not static :(((
>
> Gary
>
> On Wed, Jun 14, 2023, 06:50 Maxim Solodovnik <so...@gmail.com> wrote:
>
> > It seems I have API related question:
> >
> > FileItemHeadersImpl is not public anymore :((
> > How it can be created? :)))
> >
> > On Wed, 14 Jun 2023 at 17:28, Maxim Solodovnik <so...@gmail.com>
> > wrote:
> > >
> > > It seems new jar file missing `Automatic-Module-Name` would it be
> > > possible to add it? :)
> > >
> > > On Wed, 14 Jun 2023 at 17:10, Maxim Solodovnik <so...@gmail.com>
> > wrote:
> > > >
> > > > On Wed, 14 Jun 2023 at 16:53, Gary Gregory <ga...@gmail.com>
> > wrote:
> > > > >
> > > > > Glad to hear that your testing went well.
> > > > >
> > > > > Some of the documentation needs to be rewritten, so I'll look at
> > that next
> > > > > unless someone else gets to it first.
> > > > >
> > > > > I plan on creating a release candidate for a 2.0.0-beta1 or 2.0.0-M1
> > within
> > > > > a week or so.
> > > >
> > > > Great news :)
> > > >
> > > > > Since this is a major release I think it is important to make
> > > > > at least one version available before 2.0.0 sets the API in stone for
> > > > > binary compatibility.
> > > >
> > > > M1 sounds very reasonable :)
> > > >
> > > > >
> > > > > Gary
> > > > >
> > > > > On Wed, Jun 14, 2023, 01:15 Dennis Kieselhorst <de...@apache.org>
> > wrote:
> > > > >
> > > > > > Hi Gary,
> > > > > >
> > > > > > successfully tested the latest SNAPSHOT with the new module
> > structure
> > > > > > yesterday. Please release it.
> > > > > >
> > > > > > Thanks,
> > > > > > Dennis
> > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > > > >
> > > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Best regards,
> > > > Maxim
> > >
> > >
> > >
> > > --
> > > Best regards,
> > > Maxim
> >
> >
> >
> > --
> > Best regards,
> > Maxim
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
--
Best regards,
Maxim
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?
Posted by Gary Gregory <ga...@gmail.com>.
A FileItemHeadersImpl is created by calling
AbstractFileUpload#newFileItemHeaders()
Gary
On Wed, Jun 14, 2023, 06:50 Maxim Solodovnik <so...@gmail.com> wrote:
> It seems I have API related question:
>
> FileItemHeadersImpl is not public anymore :((
> How it can be created? :)))
>
> On Wed, 14 Jun 2023 at 17:28, Maxim Solodovnik <so...@gmail.com>
> wrote:
> >
> > It seems new jar file missing `Automatic-Module-Name` would it be
> > possible to add it? :)
> >
> > On Wed, 14 Jun 2023 at 17:10, Maxim Solodovnik <so...@gmail.com>
> wrote:
> > >
> > > On Wed, 14 Jun 2023 at 16:53, Gary Gregory <ga...@gmail.com>
> wrote:
> > > >
> > > > Glad to hear that your testing went well.
> > > >
> > > > Some of the documentation needs to be rewritten, so I'll look at
> that next
> > > > unless someone else gets to it first.
> > > >
> > > > I plan on creating a release candidate for a 2.0.0-beta1 or 2.0.0-M1
> within
> > > > a week or so.
> > >
> > > Great news :)
> > >
> > > > Since this is a major release I think it is important to make
> > > > at least one version available before 2.0.0 sets the API in stone for
> > > > binary compatibility.
> > >
> > > M1 sounds very reasonable :)
> > >
> > > >
> > > > Gary
> > > >
> > > > On Wed, Jun 14, 2023, 01:15 Dennis Kieselhorst <de...@apache.org>
> wrote:
> > > >
> > > > > Hi Gary,
> > > > >
> > > > > successfully tested the latest SNAPSHOT with the new module
> structure
> > > > > yesterday. Please release it.
> > > > >
> > > > > Thanks,
> > > > > Dennis
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > > >
> > > > >
> > >
> > >
> > >
> > > --
> > > Best regards,
> > > Maxim
> >
> >
> >
> > --
> > Best regards,
> > Maxim
>
>
>
> --
> Best regards,
> Maxim
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?
Posted by Maxim Solodovnik <so...@gmail.com>.
It seems I have API related question:
FileItemHeadersImpl is not public anymore :((
How it can be created? :)))
On Wed, 14 Jun 2023 at 17:28, Maxim Solodovnik <so...@gmail.com> wrote:
>
> It seems new jar file missing `Automatic-Module-Name` would it be
> possible to add it? :)
>
> On Wed, 14 Jun 2023 at 17:10, Maxim Solodovnik <so...@gmail.com> wrote:
> >
> > On Wed, 14 Jun 2023 at 16:53, Gary Gregory <ga...@gmail.com> wrote:
> > >
> > > Glad to hear that your testing went well.
> > >
> > > Some of the documentation needs to be rewritten, so I'll look at that next
> > > unless someone else gets to it first.
> > >
> > > I plan on creating a release candidate for a 2.0.0-beta1 or 2.0.0-M1 within
> > > a week or so.
> >
> > Great news :)
> >
> > > Since this is a major release I think it is important to make
> > > at least one version available before 2.0.0 sets the API in stone for
> > > binary compatibility.
> >
> > M1 sounds very reasonable :)
> >
> > >
> > > Gary
> > >
> > > On Wed, Jun 14, 2023, 01:15 Dennis Kieselhorst <de...@apache.org> wrote:
> > >
> > > > Hi Gary,
> > > >
> > > > successfully tested the latest SNAPSHOT with the new module structure
> > > > yesterday. Please release it.
> > > >
> > > > Thanks,
> > > > Dennis
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > >
> > > >
> >
> >
> >
> > --
> > Best regards,
> > Maxim
>
>
>
> --
> Best regards,
> Maxim
--
Best regards,
Maxim
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?
Posted by Maxim Solodovnik <so...@gmail.com>.
It seems new jar file missing `Automatic-Module-Name` would it be
possible to add it? :)
On Wed, 14 Jun 2023 at 17:10, Maxim Solodovnik <so...@gmail.com> wrote:
>
> On Wed, 14 Jun 2023 at 16:53, Gary Gregory <ga...@gmail.com> wrote:
> >
> > Glad to hear that your testing went well.
> >
> > Some of the documentation needs to be rewritten, so I'll look at that next
> > unless someone else gets to it first.
> >
> > I plan on creating a release candidate for a 2.0.0-beta1 or 2.0.0-M1 within
> > a week or so.
>
> Great news :)
>
> > Since this is a major release I think it is important to make
> > at least one version available before 2.0.0 sets the API in stone for
> > binary compatibility.
>
> M1 sounds very reasonable :)
>
> >
> > Gary
> >
> > On Wed, Jun 14, 2023, 01:15 Dennis Kieselhorst <de...@apache.org> wrote:
> >
> > > Hi Gary,
> > >
> > > successfully tested the latest SNAPSHOT with the new module structure
> > > yesterday. Please release it.
> > >
> > > Thanks,
> > > Dennis
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> > >
>
>
>
> --
> Best regards,
> Maxim
--
Best regards,
Maxim
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?
Posted by Maxim Solodovnik <so...@gmail.com>.
On Wed, 14 Jun 2023 at 16:53, Gary Gregory <ga...@gmail.com> wrote:
>
> Glad to hear that your testing went well.
>
> Some of the documentation needs to be rewritten, so I'll look at that next
> unless someone else gets to it first.
>
> I plan on creating a release candidate for a 2.0.0-beta1 or 2.0.0-M1 within
> a week or so.
Great news :)
> Since this is a major release I think it is important to make
> at least one version available before 2.0.0 sets the API in stone for
> binary compatibility.
M1 sounds very reasonable :)
>
> Gary
>
> On Wed, Jun 14, 2023, 01:15 Dennis Kieselhorst <de...@apache.org> wrote:
>
> > Hi Gary,
> >
> > successfully tested the latest SNAPSHOT with the new module structure
> > yesterday. Please release it.
> >
> > Thanks,
> > Dennis
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
--
Best regards,
Maxim
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[FileUpload] 2.0.0-M1 soon [Was] Re: Re: Release Commons Fileupload 1.4.1?
Posted by Gary Gregory <ga...@gmail.com>.
Glad to hear that your testing went well.
Some of the documentation needs to be rewritten, so I'll look at that next
unless someone else gets to it first.
I plan on creating a release candidate for a 2.0.0-beta1 or 2.0.0-M1 within
a week or so. Since this is a major release I think it is important to make
at least one version available before 2.0.0 sets the API in stone for
binary compatibility.
Gary
On Wed, Jun 14, 2023, 01:15 Dennis Kieselhorst <de...@apache.org> wrote:
> Hi Gary,
>
> successfully tested the latest SNAPSHOT with the new module structure
> yesterday. Please release it.
>
> Thanks,
> Dennis
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>