You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/11/05 10:03:38 UTC
[PR] protect 1.0.x branch [incubator-pekko-management]
pjfanning opened a new pull request, #135:
URL: https://github.com/apache/incubator-pekko-management/pull/135
need to have 1.0.x branch because pekko-management tests no longer pass with pekko 1.1 snapshots due to slf4j upgrade in pekko 1.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protect 1.0.x branch [incubator-pekko-management]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #135:
URL: https://github.com/apache/incubator-pekko-management/pull/135#issuecomment-1793715176
> So for me, its highly sus (i.e. suspicious) that we have to create another branch for even though we are meant to be supporting sem ver so there is no reason that Pekko 1.1.x shouldn't work with pekko-management.
>
> Probably missing something, but thats why I said earlier I need to take a proper look at whats going on.
see #136 - if this other PR is acceptable, we won't need to branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protect 1.0.x branch [incubator-pekko-management]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #135:
URL: https://github.com/apache/incubator-pekko-management/pull/135#issuecomment-1793714762
So for me, its highly sus (i.e. suspicious) that we have to create another branch for even though we are meant to be supporting sem ver so there is no reason that Pekko 1.1.x shouldn't work with pekko-management.
Probably missing something, but thats why I said earlier I need to take a proper look at whats going on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protect 1.0.x branch [incubator-pekko-management]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #135:
URL: https://github.com/apache/incubator-pekko-management/pull/135#issuecomment-1793696584
I'll check this out later, have some questions regarding what happened here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protect 1.0.x branch [incubator-pekko-management]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #135:
URL: https://github.com/apache/incubator-pekko-management/pull/135#issuecomment-1793703997
I suspect that it might be better to handle the CI test failures by slightly complicating the build than to branch this repo.
Ideally, we would continue to have just a pekko-management 1.0 line and that it works with pekko(-core) 1.0 and 1.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protect 1.0.x branch [incubator-pekko-management]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #135:
URL: https://github.com/apache/incubator-pekko-management/pull/135#issuecomment-1793716454
Cool ill check it out later, possible tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protect 1.0.x branch [incubator-pekko-management]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #135: protect 1.0.x branch
URL: https://github.com/apache/incubator-pekko-management/pull/135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org