You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2020/11/15 01:47:01 UTC
[incubator-superset] 02/05: hello world modal
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/SO-1117-modal
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
commit bfac037e04453d44af372d9ed524fefbc2680d96
Author: hughhhh <hu...@gmail.com>
AuthorDate: Sun Nov 1 18:52:31 2020 -0800
hello world modal
---
superset-frontend/src/SqlLab/components/ResultSet.tsx | 1 -
superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx | 10 +++++++---
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/superset-frontend/src/SqlLab/components/ResultSet.tsx b/superset-frontend/src/SqlLab/components/ResultSet.tsx
index d1a2c40..2c3e7f5 100644
--- a/superset-frontend/src/SqlLab/components/ResultSet.tsx
+++ b/superset-frontend/src/SqlLab/components/ResultSet.tsx
@@ -388,7 +388,6 @@ export default class ResultSet extends React.PureComponent<
</div>
<div>{progressBar}</div>
<div>{trackingUrl}</div>
- <SaveDatasetModal />
</div>
);
}
diff --git a/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx b/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx
index 2b27841..acdb279 100644
--- a/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx
+++ b/superset-frontend/src/SqlLab/components/SaveDatasetModal.tsx
@@ -20,7 +20,11 @@
import React, { FunctionComponent } from 'react';
import Modal from 'src/common/components/Modal';
-
+// eslint-disable-next-line no-empty-pattern
export const SaveDatasetModal = ({}) => {
- return (<div>SaveDatasetModal</div>)
-}
+ return (
+ <Modal show onHide={() => {}} title="Save a new dataset">
+ <div>hello world</div>
+ </Modal>
+ );
+};