You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/05 07:50:49 UTC

[GitHub] [spark] viirya commented on pull request #29087: [SPARK-28227][SQL] Support TRANSFORM with aggregation/window/lateralView

viirya commented on pull request #29087:
URL: https://github.com/apache/spark/pull/29087#issuecomment-754468077


   > > And I did't see any UT about this feature. any thing wrong? Should I fix this problem with a new jira ticket?
   > 
   > Yea, I think we just forgot to add tests in #22696, so we need to follow the behaviour that the migration guide defines and add tests for it. cc: @cloud-fan @viirya
   
   Hm? Seems we were missing some tests with `havingWithoutGroupByAsWhere`  as true?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org