You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/07/02 18:18:31 UTC

Review Request 12232: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12232/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.


Bugs: CLOUDSTACK-3324


Repository: cloudstack-git


Description
-------

CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42

During upgrade system vm template from 4.1 to 4.2 there are case sensitive checks happening which needs to be fixed and improve by generalizing the code for all hypervisors 


Diffs
-----

  engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java da68348 

Diff: https://reviews.apache.org/r/12232/diff/


Testing
-------

Tested locally


Thanks,

Harikrishna Patnala


Re: Review Request 12232: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12232/#review22713
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On July 2, 2013, 4:24 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12232/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 4:24 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3324
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42
> 
> During upgrade system vm template from 4.1 to 4.2 there are case sensitive checks happening which needs to be fixed and improve by generalizing the code for all hypervisors 
> 
> submitted another review request to be applied on master-6-17-stable(faced some merge conflicts with master patch)
> https://reviews.apache.org/r/12233/
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java da68348 
> 
> Diff: https://reviews.apache.org/r/12232/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12232: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12232/
-----------------------------------------------------------

(Updated July 2, 2013, 4:24 p.m.)


Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.


Changes
-------

submitted another review request to be applied on master-6-17-stable(faced some merge conflicts with master patch)
https://reviews.apache.org/r/12233/


Bugs: CLOUDSTACK-3324


Repository: cloudstack-git


Description (updated)
-------

CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42

During upgrade system vm template from 4.1 to 4.2 there are case sensitive checks happening which needs to be fixed and improve by generalizing the code for all hypervisors 

submitted another review request to be applied on master-6-17-stable(faced some merge conflicts with master patch)
https://reviews.apache.org/r/12233/


Diffs
-----

  engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java da68348 

Diff: https://reviews.apache.org/r/12232/diff/


Testing
-------

Tested locally


Thanks,

Harikrishna Patnala