[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3937: feat: add etag for objectMeta

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3937:
URL: https://github.com/apache/arrow-rs/pull/3937#discussion_r1151210993


##########
object_store/src/lib.rs:
##########
@@ -518,6 +518,8 @@ pub struct ObjectMeta {
     pub last_modified: DateTime<Utc>,
     /// The size in bytes of the object
     pub size: usize,
+    /// The unique identifier for the object
+    pub e_tag: String,

Review Comment:
   In fact returning `None` might be better than using a hash of datetime for the stores such as LocalFilesystem. Makes it explicit. What do you think?



##########
object_store/src/lib.rs:
##########
@@ -518,6 +518,8 @@ pub struct ObjectMeta {
     pub last_modified: DateTime<Utc>,
     /// The size in bytes of the object
     pub size: usize,
+    /// The unique identifier for the object
+    pub e_tag: String,

Review Comment:
   ```suggestion
       pub e_tag: Option<String>,
   ```
   Perhaps?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org