You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/31 16:19:52 UTC
[GitHub] [rocketmq] brucelwl opened a new pull request #1900: fix -> might
lead to class loading deadlock
brucelwl opened a new pull request #1900: fix -> might lead to class loading deadlock
URL: https://github.com/apache/rocketmq/pull/1900
Referencing subclass BooleanConstantExpression from superclass ConstantExpression initializer might lead to class loading deadlock
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] ShannonDing commented on a change in pull request #1900:
fix -> might lead to class loading deadlock
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on a change in pull request #1900: fix -> might lead to class loading deadlock
URL: https://github.com/apache/rocketmq/pull/1900#discussion_r401339424
##########
File path: filter/src/main/java/org/apache/rocketmq/filter/expression/BooleanConstantExpression.java
##########
@@ -0,0 +1,20 @@
+package org.apache.rocketmq.filter.expression;
Review comment:
lack of APLv2 header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] ShannonDing commented on a change in pull request #1900:
fix -> might lead to class loading deadlock
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on a change in pull request #1900: fix -> might lead to class loading deadlock
URL: https://github.com/apache/rocketmq/pull/1900#discussion_r401339309
##########
File path: filter/src/main/java/org/apache/rocketmq/filter/expression/BooleanConstantExpression.java
##########
@@ -0,0 +1,20 @@
+package org.apache.rocketmq.filter.expression;
+
+/**
+ * Created by bruce in 2020/3/31 23:52
+ */
Review comment:
pls remove the author info in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] brucelwl commented on issue #1900: fix -> might lead to
class loading deadlock
Posted by GitBox <gi...@apache.org>.
brucelwl commented on issue #1900: fix -> might lead to class loading deadlock
URL: https://github.com/apache/rocketmq/pull/1900#issuecomment-607064951
> hello，
>
> 1. it is better to create an issue linked to this PR;
> 2. pls move the PR to develop branch;
> 3. the APLv2 should be included in the new file.
> Could you pls check this or again?
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] brucelwl closed pull request #1900: fix -> might lead to
class loading deadlock
Posted by GitBox <gi...@apache.org>.
brucelwl closed pull request #1900: fix -> might lead to class loading deadlock
URL: https://github.com/apache/rocketmq/pull/1900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] ShannonDing commented on issue #1900: fix -> might lead
to class loading deadlock
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #1900: fix -> might lead to class loading deadlock
URL: https://github.com/apache/rocketmq/pull/1900#issuecomment-607047323
hello，
1. it is better to create an issue linked to this PR;
2. pls move the PR to develop branch;
3. the APLv2 should be included in the new file.
Could you pls check this or again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services