[GitHub] [solr] risdenk commented on a diff in pull request #1206: SOLR-16564: Migrate to using DEFAULT_TEST_COLLECTION_NAME constant through out tests

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #1206:
URL: https://github.com/apache/solr/pull/1206#discussion_r1037568771


##########
solr/core/src/test/org/apache/solr/cloud/LeaderVoteWaitTimeoutTest.java:
##########
@@ -179,74 +179,78 @@ public void basicTest() throws Exception {
 
   @Test
   public void testMostInSyncReplicasCanWinElection() throws Exception {
-    final String collectionName = "collection1";
-    CollectionAdminRequest.createCollection(collectionName, 1, 3)
+    // final String collectionName = "collection1";

Review Comment:
   I think this could be 
   
   ```
   final String collectionName = DEFAULT_TEST_COLLECTION_NAME;
   ```
   
   which would make the diff a lot smaller?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org