You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/14 05:07:54 UTC
[GitHub] [dolphinscheduler] Hou-Shuaishuai opened a new issue #8862: [Bug][api] Different users cannot use the same project name
Hou-Shuaishuai opened a new issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Different users cannot use the same project name .
### What you expected to happen
The current user can't see other people's project lists and should theoretically be able to own projects that don't exist under the current user
### How to reproduce
Create two users. When user 1 creates a project named ETL, user 2 reports a project name error when creating another project named ETL
### Anything else
_No response_
### Version
2.0.3
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1067733709
Hi @Hou-Shuaishuai this is a easy issue, can you try to submit a pr to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1066346104
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1074861077
> In the process of modification, I found that 'projectMapper.queryByName(projectName)' was used in 'dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java', and I learned the concept of work flow user through 'pydolphinscheduler/src/pydolphinscheduler/core/default_config.yaml'. It was then discovered that user 1's project could be authorized to user 2.
>
> If user 1 has an ETL project, and user 2 has an ETL project, and grants user 1's ETL project to user 2, then user 2's project list will have two ETL projects, one from user 1 and one from user 2. The problem is that the PyDolphinScheduler module queries projectCode by projectName and it may not be clear to the PydolphinScheduler user which user the project is from. It may be neither default.user.name nor default.workflow.user in 'pydolphinscheduler/src/pydolphinscheduler/core/default_config.yaml'. So it makes sense that the projectName global is unique in the PyDolphinScheduler module.
Hi @Hou-Shuaishuai, It should not be a problem for pydolphinscheduler, At least we could grant projects to a specific user in web UI. For now pydolphinscheduler will raise error when one user have more than one project with same name. But if our web UI find out how to handle this situation, pydolphinscheduler could also do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Hou-Shuaishuai commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
Hou-Shuaishuai commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1068741414
Yes, since I'm not familiar with the code and have work to do, it may not be that fast.
------------------ 原始邮件 ------------------
发件人: "apache/dolphinscheduler" ***@***.***>;
发送时间: 2022年3月15日(星期二) 下午5:09
***@***.***>;
***@***.******@***.***>;
主题: Re: [apache/dolphinscheduler] [Bug][api] Different users cannot use the same project name (Issue #8862)
Hi @Hou-Shuaishuai this is a easy issue, can you try to submit a pr to fix it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Hou-Shuaishuai commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
Hou-Shuaishuai commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1072974732
In the process of modification, I found that 'projectMapper.queryByName(projectName)' was used in 'dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java', and I learned the concept of work flow user through 'pydolphinscheduler/src/pydolphinscheduler/core/default_config.yaml'. It was then discovered that user 1's project could be authorized to user 2.
If user 1 has an ETL project, and user 2 has an ETL project, and grants user 1's ETL project to user 2, then user 2's project list will have two ETL projects, one from user 1 and one from user 2. The problem is that the PyDolphinScheduler module queries projectCode by projectName and it may not be clear to the PydolphinScheduler user which user the project is from. It may be neither default.user.name nor default.workflow.user in 'pydolphinscheduler/src/pydolphinscheduler/core/default_config.yaml'. So it makes sense that the projectName global is unique in the PyDolphinScheduler module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1073018483
Will take a look tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Hou-Shuaishuai commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
Hou-Shuaishuai commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1073168139
If multiple projectnames are the same when scheduling dependencies because of project authorization, it does create ambiguity, so projectName that are globally unique should not be a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1074922453
I add a label discussion for this issue. It need more discuss before we do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Hou-Shuaishuai commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
Hou-Shuaishuai commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1076299084
You mean projectName is unique within the user-group and can be displayed with the same projectName from different user-groups during scheduling? I think we can confirm with Issue [#9016](https://github.com/apache/dolphinscheduler/issues/9016) how to modify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1077036162
> You mean projectName is unique within the user-group and can be displayed with the same projectName from different user-groups during scheduling?
Yeah, that's what I mean. And it seems this issue is related to many other code we have to deal with it carefully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1074867556
> If multiple projectnames are the same when scheduling dependencies because of project authorization, it does create ambiguity, so projectName that are globally unique should not be a bug
I think we should correct it and make it support to user-group-level but not for global. Global is odd in this situation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1073011812
> In the process of modification, I found that 'projectMapper.queryByName(projectName)' was used in 'dolphinscheduler-python/src/main/java/org/apache/dolphinscheduler/server/PythonGatewayServer.java', and I learned the concept of work flow user through 'pydolphinscheduler/src/pydolphinscheduler/core/default_config.yaml'. It was then discovered that user 1's project could be authorized to user 2.
>
> If user 1 has an ETL project, and user 2 has an ETL project, and grants user 1's ETL project to user 2, then user 2's project list will have two ETL projects, one from user 1 and one from user 2. The problem is that the PyDolphinScheduler module queries projectCode by projectName and it may not be clear to the PydolphinScheduler user which user the project is from. It may be neither default.user.name nor default.workflow.user in 'pydolphinscheduler/src/pydolphinscheduler/core/default_config.yaml'. So it makes sense that the projectName global is unique in the PyDolphinScheduler module.
@zhongjiajie can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #8862: [Bug][api] Different users cannot use the same project name
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #8862:
URL: https://github.com/apache/dolphinscheduler/issues/8862#issuecomment-1069826186
> Yes, since I'm not familiar with the code and have work to do, it may not be that fast
OK, I assign this issue to you, and you can fix it at your own pace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org