You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Bryn Cooke (Jira)" <ji...@apache.org> on 2020/06/10 09:04:04 UTC
[jira] [Comment Edited] (CASSANDRA-15677) Topology events are not
sent to clients if the nodes use the same network interface
[ https://issues.apache.org/jira/browse/CASSANDRA-15677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130402#comment-17130402 ]
Bryn Cooke edited comment on CASSANDRA-15677 at 6/10/20, 9:03 AM:
------------------------------------------------------------------
It's 0.0.2 on trunk, which has the changes needed.
It looks like only 65de93d4fe2b48565955ae7e49adbadf510ed3c5 was taken from the PR?
3fe0b77b985d76e1456241e56b4b92a965926d72 is needed as well at minimum.
TIL that github PRs do not display ordered by commit and instead in chronological order: [https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-in-the-wrong-order]
My local git log looks like this:
{noformat}
commit 5356c267de3bb1306f52c05a8afbb01dafddf28e (HEAD -> CASSANDRA-15677, origin/CASSANDRA-15677)
Author: bryn <br...@gmail.com>
Date: Mon Jun 8 11:02:42 2020 +0100 CASSANDRA-15677 Add shutdown to JMX thread pool to avoid metaspace errors associated with thread leaks.
There are still other thread shutdown issues remaining, but this seems to be the most serious one.
commit 65de93d4fe2b48565955ae7e49adbadf510ed3c5
Author: Alan Boudreault <al...@kovaro.ca>
Date: Mon Mar 30 14:27:55 2020 -0400 CASSANDRA-15677 Make sure topology events are sent to clients when using a single network interface
commit 3fe0b77b985d76e1456241e56b4b92a965926d72
Author: bryn <br...@gmail.com>
Date: Wed May 20 16:16:33 2020 +0100 CASSANDRA-15677 Add the ability to run dTests on the same interface.
commit 7bbc97e5835b64c49fd418581f5a45429c1806b1
Merge: 69ea5ffdbc 04b0049831
Author: Alex Petrov <ol...@gmail.com>
Date: Fri Jun 5 19:34:13 2020 +0200 Merge branch 'cassandra-3.11' into trunk
{noformat}
was (Author: bryncooke):
It's 0.0.2 on trunk, which has the changes needed.
It looks like only 65de93d4fe2b48565955ae7e49adbadf510ed3c5 was taken from the PR?
3fe0b77b985d76e1456241e56b4b92a965926d72 is needed as well at minimum.
TIL that github PRs do not display ordered by commit and instead in chronological order: [https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-in-the-wrong-order]
My local git log looks like this:
{noformat}
commit 5356c267de3bb1306f52c05a8afbb01dafddf28e (HEAD -> CASSANDRA-15677, origin/CASSANDRA-15677)
Author: bryn <br...@gmail.com>
Date: Mon Jun 8 11:02:42 2020 +0100 CASSANDRA-15677 Add shutdown to JMX thread pool to avoid metaspace errors associated with thread leaks.
There are still other thread shutdown issues remaining, but this seems to be the most serious one.
commit 65de93d4fe2b48565955ae7e49adbadf510ed3c5
Author: Alan Boudreault <al...@kovaro.ca>
Date: Mon Mar 30 14:27:55 2020 -0400 CASSANDRA-15677 Make sure topology events are sent to clients when using a single network interface
commit 3fe0b77b985d76e1456241e56b4b92a965926d72
Author: bryn <br...@gmail.com>
Date: Wed May 20 16:16:33 2020 +0100 CASSANDRA-15677 Add the ability to run dTests on the same interface.
commit 7bbc97e5835b64c49fd418581f5a45429c1806b1
Merge: 69ea5ffdbc 04b0049831
Author: Alex Petrov <ol...@gmail.com>
Date: Fri Jun 5 19:34:13 2020 +0200 Merge branch 'cassandra-3.11' into trunk
{noformat}
> Topology events are not sent to clients if the nodes use the same network interface
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-15677
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15677
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
> Reporter: Alan Boudreault
> Assignee: Bryn Cooke
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha5
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> *This bug only happens when the cassandra nodes are configured to use a single network interface (ip) but different ports. See CASSANDRA-7544.*
> Issue: The topology events aren't sent to clients. The problem is that the port is not taken into account when determining if we send it or not:
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/Server.java#L624
> To reproduce:
> {code}
> # I think the cassandra-test branch is required to get the -S option (USE_SINGLE_INTERFACE)
> ccm create -n4 local40 -v 4.0-alpha2 -S
> {code}
>
> Then run this small python driver script:
> {code}
> import time
> from cassandra.cluster import Cluster
> cluster = Cluster()
> session = cluster.connect()
> while True:
> print(cluster.metadata.all_hosts())
> print([h.is_up for h in cluster.metadata.all_hosts()])
> time.sleep(5)
> {code}
> Then decommission a node:
> {code}
> ccm node2 nodetool disablebinary
> ccm node2 nodetool decommission
> {code}
>
> You should see that the node is never removed from the client cluster metadata and the reconnector started.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org