Re: svn commit: r738598 - in /incubator/openwebbeans/trunk: ./ webbeans-impl/ webbeans-impl/src/main/java/org/apache/webbeans/component/ webbeans-impl/src/main/java/org/apache/webbeans/config/ webbeans-impl/src/main/java/org/apache/webbeans/decorator/xml/ ...

[Kevan Miller <ke...@gmail.com>]

On Jan 28, 2009, at 2:49 PM, gerdogdu@apache.org wrote:

> Author: gerdogdu
> Date: Wed Jan 28 19:49:55 2009
> New Revision: 738598
>
> URL: http://svn.apache.org/viewvc?rev=738598&view=rev
> Log:
> OWB-71 support PersistenceUnit JPA injection on behalf of Mark  
> Struberg, thanks

I'd prefer to see Mark committing Mark's work. This is not a complaint/ 
criticism about what either of you have done. Just want to raise a few  
points:

1) Mark is a committer on the project. It's perfectly well within his  
rights to commit code, without asking for a review. The development  
process we are following is CTR (commit then review). All project  
members are expected to review the work that other committers are  
doing. If they see a problem with some code update, simply discuss the  
change and explain what you don't like about it. Any committer on the  
project has the power to veto (-1) a particular svn commit. Much  
better to resolve a dispute via discussion.
2) It's also perfectly reasonable to ask someone to look at a code  
patch and solicit opinions. This is a good way of "discussing" a  
potentially controversial change. Also, it's a good way to ease your  
way into a new project (or a new component in a project). However,  
would expect that this is a short-term condition.
3) After a review, I'd like to see Mark committing his code...

--kevan

Re: svn commit: r738598 - in /incubator/openwebbeans/trunk: ./ webbeans-impl/ webbeans-impl/src/main/java/org/apache/webbeans/component/ webbeans-impl/src/main/java/org/apache/webbeans/config/ webbeans-impl/src/main/java/org/apache/webbeans/decorator/xml/ ...

[Gurkan Erdogdu <gu...@yahoo.com>]

Thanks for the clarification Kevan.

/Gurkan


________________________________
From: Kevan Miller <ke...@gmail.com>
To: openwebbeans-dev@incubator.apache.org
Sent: Wednesday, January 28, 2009 11:19:04 PM
Subject: Re: svn commit: r738598 - in /incubator/openwebbeans/trunk: ./ webbeans-impl/ webbeans-impl/src/main/java/org/apache/webbeans/component/ webbeans-impl/src/main/java/org/apache/webbeans/config/ webbeans-impl/src/main/java/org/apache/webbeans/decorator/xml/ ...


On Jan 28, 2009, at 2:49 PM, gerdogdu@apache.org wrote:

> Author: gerdogdu
> Date: Wed Jan 28 19:49:55 2009
> New Revision: 738598
> 
> URL: http://svn.apache.org/viewvc?rev=738598&view=rev
> Log:
> OWB-71 support PersistenceUnit JPA injection on behalf of Mark Struberg, thanks

I'd prefer to see Mark committing Mark's work. This is not a complaint/criticism about what either of you have done. Just want to raise a few points:

1) Mark is a committer on the project. It's perfectly well within his rights to commit code, without asking for a review. The development process we are following is CTR (commit then review). All project members are expected to review the work that other committers are doing. If they see a problem with some code update, simply discuss the change and explain what you don't like about it. Any committer on the project has the power to veto (-1) a particular svn commit. Much better to resolve a dispute via discussion.
2) It's also perfectly reasonable to ask someone to look at a code patch and solicit opinions. This is a good way of "discussing" a potentially controversial change. Also, it's a good way to ease your way into a new project (or a new component in a project). However, would expect that this is a short-term condition.
3) After a review, I'd like to see Mark committing his code...

--kevan