You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/08/20 12:03:01 UTC
[GitHub] [commons-lang] rednikeeg opened a new pull request, #935: LANG-1603: Deprecate Fraction class
rednikeeg opened a new pull request, #935:
URL: https://github.com/apache/commons-lang/pull/935
jira issue: https://issues.apache.org/jira/browse/LANG-1603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #935: LANG-1603: Deprecate Fraction class
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #935:
URL: https://github.com/apache/commons-lang/pull/935#discussion_r950693989
##########
src/main/java/org/apache/commons/lang3/math/Fraction.java:
##########
@@ -31,8 +31,10 @@
* based and thus suffers from various overflow issues. For a BigInteger based
* equivalent, please see the Commons Math BigFraction class. </p>
*
+ * @deprecated for fraction implementation from commons-numbers
Review Comment:
Please add a URL to the Javadoc for the favored implementation. You are also missing the '@depracted' Javadoc tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #935: LANG-1603: Deprecate Fraction class
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #935:
URL: https://github.com/apache/commons-lang/pull/935#discussion_r950693989
##########
src/main/java/org/apache/commons/lang3/math/Fraction.java:
##########
@@ -31,8 +31,10 @@
* based and thus suffers from various overflow issues. For a BigInteger based
* equivalent, please see the Commons Math BigFraction class. </p>
*
+ * @deprecated for fraction implementation from commons-numbers
Review Comment:
Please add a URL to the Javadoc for the favored implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] rednikeeg closed pull request #935: LANG-1603: Deprecate Fraction class
Posted by "rednikeeg (via GitHub)" <gi...@apache.org>.
rednikeeg closed pull request #935: LANG-1603: Deprecate Fraction class
URL: https://github.com/apache/commons-lang/pull/935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #935: LANG-1603: Deprecate Fraction class
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #935:
URL: https://github.com/apache/commons-lang/pull/935#discussion_r951787970
##########
src/main/java/org/apache/commons/lang3/math/Fraction.java:
##########
@@ -31,7 +31,8 @@
* based and thus suffers from various overflow issues. For a BigInteger based
* equivalent, please see the Commons Math BigFraction class. </p>
*
- * @deprecated for fraction implementation from commons-numbers
+ * @deprecated for <a href="https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/index.html">Fraction</a>
+ * from commons-numbers
Review Comment:
Still not quite right: You talk about Commons Numbers but link to Commons Math as a whole. You want the URL to the Commons Numbers Fraction package or class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] rednikeeg commented on a diff in pull request #935: LANG-1603: Deprecate Fraction class
Posted by GitBox <gi...@apache.org>.
rednikeeg commented on code in PR #935:
URL: https://github.com/apache/commons-lang/pull/935#discussion_r951789781
##########
src/main/java/org/apache/commons/lang3/math/Fraction.java:
##########
@@ -31,8 +31,10 @@
* based and thus suffers from various overflow issues. For a BigInteger based
* equivalent, please see the Commons Math BigFraction class. </p>
*
+ * @deprecated for fraction implementation from commons-numbers
Review Comment:
Added reference to the favored implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #935: LANG-1603: Deprecate Fraction class
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #935:
URL: https://github.com/apache/commons-lang/pull/935#discussion_r990638476
##########
src/main/java/org/apache/commons/lang3/math/Fraction.java:
##########
@@ -31,8 +31,11 @@
* based and thus suffers from various overflow issues. For a BigInteger based
* equivalent, please see the Commons Math BigFraction class. </p>
*
+ * @deprecated for <a href="https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/org/apache/commons/math3/fraction/Fraction.html">Fraction</a>
Review Comment:
We can't just deprecate the class without documenting how to port your current code to the other API IMO. For example, what do you do with `Fraction#invert()`? Each method must be documented, otherwise, it's a disservice, and everyone using the class is left having to do their own investigation and mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a diff in pull request #935: LANG-1603: Deprecate Fraction class
Posted by GitBox <gi...@apache.org>.
garydgregory commented on code in PR #935:
URL: https://github.com/apache/commons-lang/pull/935#discussion_r950693989
##########
src/main/java/org/apache/commons/lang3/math/Fraction.java:
##########
@@ -31,8 +31,10 @@
* based and thus suffers from various overflow issues. For a BigInteger based
* equivalent, please see the Commons Math BigFraction class. </p>
*
+ * @deprecated for fraction implementation from commons-numbers
Review Comment:
Please add a URL to the Javadoc for the favored implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] rednikeeg commented on a diff in pull request #935: LANG-1603: Deprecate Fraction class
Posted by GitBox <gi...@apache.org>.
rednikeeg commented on code in PR #935:
URL: https://github.com/apache/commons-lang/pull/935#discussion_r951796533
##########
src/main/java/org/apache/commons/lang3/math/Fraction.java:
##########
@@ -31,7 +31,8 @@
* based and thus suffers from various overflow issues. For a BigInteger based
* equivalent, please see the Commons Math BigFraction class. </p>
*
- * @deprecated for fraction implementation from commons-numbers
+ * @deprecated for <a href="https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/index.html">Fraction</a>
+ * from commons-numbers
Review Comment:
Aw, sorry, resolved that moment already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #935: LANG-1603: Deprecate Fraction class
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #935:
URL: https://github.com/apache/commons-lang/pull/935#issuecomment-1224078458
The discussion in https://issues.apache.org/jira/browse/LANG-1603 does not make it clear (to me) if the proposed replacement is convenient enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #935: LANG-1603: Deprecate Fraction class
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #935:
URL: https://github.com/apache/commons-lang/pull/935#issuecomment-1221303539
# [Codecov](https://codecov.io/gh/apache/commons-lang/pull/935?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#935](https://codecov.io/gh/apache/commons-lang/pull/935?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bdc72af) into [master](https://codecov.io/gh/apache/commons-lang/commit/ceb7fbb0336f21f74d2b096cc0b418d62a1a3fe1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ceb7fbb) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #935 +/- ##
============================================
- Coverage 92.01% 92.00% -0.02%
+ Complexity 7436 7434 -2
============================================
Files 189 189
Lines 15751 15751
Branches 2961 2961
============================================
- Hits 14494 14491 -3
- Misses 672 673 +1
- Partials 585 587 +2
```
| [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/935?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/commons/lang3/math/Fraction.java](https://codecov.io/gh/apache/commons-lang/pull/935/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvbWF0aC9GcmFjdGlvbi5qYXZh) | `93.70% <ø> (ø)` | |
| [...apache/commons/lang3/reflect/ConstructorUtils.java](https://codecov.io/gh/apache/commons-lang/pull/935/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvcmVmbGVjdC9Db25zdHJ1Y3RvclV0aWxzLmphdmE=) | `84.00% <0.00%> (-2.00%)` | :arrow_down: |
| [...va/org/apache/commons/lang3/CharSequenceUtils.java](https://codecov.io/gh/apache/commons-lang/pull/935/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2hhclNlcXVlbmNlVXRpbHMuamF2YQ==) | `87.09% <0.00%> (-1.62%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org