You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rdblue (via GitHub)" <gi...@apache.org> on 2023/08/13 19:43:22 UTC
[GitHub] [iceberg] rdblue commented on a diff in pull request #8147: Core: Add metadata updates for Views / Use own Builder for ViewMetadata
rdblue commented on code in PR #8147:
URL: https://github.com/apache/iceberg/pull/8147#discussion_r1292846082
##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -100,6 +117,11 @@ public int schemaId() {
public void applyTo(TableMetadata.Builder metadataBuilder) {
metadataBuilder.setCurrentSchema(schemaId);
}
+
+ @Override
+ public void applyTo(ViewMetadata.Builder viewMetadataBuilder) {
+ viewMetadataBuilder.setCurrentSchemaId(schemaId);
Review Comment:
Are we going to track `current-schema-id` in views? If not, then we don't need this operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org