[GitHub] [solr] madrob commented on a change in pull request #300: SOLR-15644: Test thread leak management.

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #300:
URL: https://github.com/apache/solr/pull/300#discussion_r718870309



##########
File path: solr/test-framework/src/java/org/apache/solr/SolrIgnoredThreadsFilter.java
##########
@@ -52,7 +56,23 @@ public boolean reject(Thread t) {
     }
     
     // These is a java pool for the collection stream api
-    if (threadName.startsWith("ForkJoinPool.")) {
+    if (threadName.startsWith("ForkJoinPool.") || threadName.startsWith("pool-")) {
+      return true;
+    }
+
+    // load balancer is leaky
+    if (threadName.startsWith("aliveCheckExecutor")) {
+      return true;
+    }
+
+
+    // we don't handle zk shutdown well, but these threads are harmless and will shortly go away
+    if (threadName.startsWith("SessionTracker")) {
+      return true;
+    }
+
+    // tools
+    if (threadName.startsWith("Reference Handler") && threadName.startsWith("Signal Dispatcher") && threadName.startsWith("Monitor") && threadName.startsWith("YJPAgent-RequestListener")) {

Review comment:
       Some of these might be useful to commit to randomized testing directly? Like I did in https://github.com/randomizedtesting/randomizedtesting/pull/284




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org