[GitHub] [iceberg] dilipbiswal edited a comment on pull request #2021: Add the cardinality check to detect ambiguous target row for MERGE INTO

[GitBox <gi...@apache.org>]

dilipbiswal edited a comment on pull request #2021:
URL: https://github.com/apache/iceberg/pull/2021#issuecomment-754187134


   @rdblue Thanks a lot. I am just thinking if 
   ```
   That works because the join will always produce the matching rows together as a group.
   ```
   is true in all cases. @aokolnychyi What do you think ?
   
   Ryan, one other thing is , we are not introducing an additional join for the cardinality check in this implementation. We are doing the same join as we were doing before but just accumulating the files using an accumulator.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org