You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by piotrz <pi...@gmail.com> on 2017/01/05 08:47:02 UTC
[Apache Flex] Code Inspection
Hi All,
Lately when I was working a lot with MDL code I miss something where I can
review code written by others.
Is there any tool available in Apache where we could do for each other Code
Inspection ? I know that I can simple review commits email but it's not same
as look into such tool like Jetbrains Upsource [1]
What do you think about such tools ? Do you use it in your companies ?
[1] https://www.jetbrains.com/upsource/features/
Thanks,
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Apache-Flex-Code-Inspection-tp57931.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [Apache Flex] Code Inspection
Posted by piotrz <pi...@gmail.com>.
Thank you! :)
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Apache-Flex-Code-Inspection-tp57931p58019.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [Apache Flex] Code Inspection
Posted by OmPrakash Muppirala <bi...@gmail.com>.
We do get discussions on pull requests to dev (2 way integration)
I will check with Infra team about this.
Thanks,
Om
On Jan 8, 2017 9:53 AM, "piotrz" <pi...@gmail.com> wrote:
> This is probably impossible sinc both things. Too bad. :(
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-
> development.2333347.n4.nabble.com/Apache-Flex-Code-
> Inspection-tp57931p58016.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
Re: [Apache Flex] Code Inspection
Posted by piotrz <pi...@gmail.com>.
This is probably impossible sinc both things. Too bad. :(
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Apache-Flex-Code-Inspection-tp57931p58016.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [Apache Flex] Code Inspection
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Yes, I received an email, but it was not cced on the dev.
It would be nice if dev got those emails as well.
On Jan 8, 2017 2:39 AM, "piotrz" <pi...@gmail.com> wrote:
> Hi Om,
>
> Just tried CI on github and add some comments to your last push :) Did you
> receive any email about that ?
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-
> development.2333347.n4.nabble.com/Apache-Flex-Code-
> Inspection-tp57931p58012.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
Re: [Apache Flex] Code Inspection
Posted by piotrz <pi...@gmail.com>.
Hi Om,
Just tried CI on github and add some comments to your last push :) Did you
receive any email about that ?
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Apache-Flex-Code-Inspection-tp57931p58012.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [Apache Flex] Code Inspection
Posted by piotrz <pi...@gmail.com>.
Thanks Om! You are right I forgot about github CI. Yes please. I will do same
from now on. :)
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Apache-Flex-Code-Inspection-tp57931p57933.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [Apache Flex] Code Inspection
Posted by OmPrakash Muppirala <bi...@gmail.com>.
All our commits goes to our github mirror almost instantaneously. The
code review feature on github is pretty good. We can give it a shot if
you are interested.
Thanks,
Om
On Jan 5, 2017 1:04 AM, "piotrz" <pi...@gmail.com> wrote:
> Hi All,
>
> Lately when I was working a lot with MDL code I miss something where I can
> review code written by others.
>
> Is there any tool available in Apache where we could do for each other Code
> Inspection ? I know that I can simple review commits email but it's not
> same
> as look into such tool like Jetbrains Upsource [1]
>
> What do you think about such tools ? Do you use it in your companies ?
>
> [1] https://www.jetbrains.com/upsource/features/
>
> Thanks,
> Piotr
>
>
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-
> development.2333347.n4.nabble.com/Apache-Flex-Code-Inspection-tp57931.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>