You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2017/07/19 14:52:20 UTC
[4/4] flink git commit: [FLINK-5541] Missing null check for localJar
in FlinkSubmitter#submitTopology
[FLINK-5541] Missing null check for localJar in FlinkSubmitter#submitTopology
This closes #4315.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/9beccec4
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/9beccec4
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/9beccec4
Branch: refs/heads/master
Commit: 9beccec4501e84cf8c9fa5e8ee0a491afb39f4ac
Parents: ae826a6
Author: zhangminglei <zm...@163.com>
Authored: Wed Jul 19 10:46:21 2017 +0800
Committer: zentol <ch...@apache.org>
Committed: Wed Jul 19 11:39:19 2017 +0200
----------------------------------------------------------------------
.../src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/9beccec4/flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java
----------------------------------------------------------------------
diff --git a/flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java b/flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java
index c36942e..5b3f609 100644
--- a/flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java
+++ b/flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkSubmitter.java
@@ -22,6 +22,7 @@ import org.apache.flink.client.program.ContextEnvironment;
import org.apache.flink.configuration.Configuration;
import org.apache.flink.configuration.GlobalConfiguration;
import org.apache.flink.configuration.JobManagerOptions;
+import org.apache.flink.util.Preconditions;
import org.apache.storm.Config;
import org.apache.storm.StormSubmitter;
@@ -120,7 +121,7 @@ public class FlinkSubmitter {
// ignore
}
}
-
+ Preconditions.checkNotNull(localJar, "LocalJar must not be null.");
LOG.info("Submitting topology " + name + " in distributed mode with conf " + serConf);
client.submitTopologyWithOpts(name, localJar, topology);
} catch (final InvalidTopologyException e) {