You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/05/31 13:45:52 UTC

[GitHub] [dolphinscheduler] JinyLeeChina commented on a change in pull request #5557: [fix 5496][master] fix npe

JinyLeeChina commented on a change in pull request #5557:
URL: https://github.com/apache/dolphinscheduler/pull/5557#discussion_r642498498



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java
##########
@@ -323,6 +324,8 @@ private void executeComplementProcess() throws Exception {
             }
             // flow end
             // execute next process instance complement data
+            ProcessDefinition processDefinition = processService.findProcessDefineById(processDefinitionId);

Review comment:
       Thanks for your contribution. Why is it need set processDefinition here? Can you describe the problems you encounter in detail

##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java
##########
@@ -930,7 +933,7 @@ private void runProcess() {
             if (!sendTimeWarning && checkProcessTimeOut(processInstance)) {
                 processAlertManager.sendProcessTimeoutAlert(processInstance,
                         processService.findProcessDefinition(processInstance.getProcessDefinitionCode(),
-                        processInstance.getProcessDefinitionVersion()));
+                                processInstance.getProcessDefinitionVersion()));

Review comment:
       Please use unified codestyle




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org