You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/26 02:37:01 UTC

[GitHub] [pulsar] 315157973 commented on a change in pull request #10015: Support set property on a namespace.

315157973 commented on a change in pull request #10015:
URL: https://github.com/apache/pulsar/pull/10015#discussion_r601976413



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -2546,6 +2546,45 @@ protected void internalSetMaxTopicsPerNamespace(Integer maxTopicsPerNamespace) {
         internalSetPolicies("max_topics_per_namespace", maxTopicsPerNamespace);
    }
 
+   protected void internalSetProperty(String key, String value) {
+       validatePoliciesReadOnlyAccess();
+       try {
+           final String path = path(POLICIES, namespaceName.toString());
+           updatePolicies(path, (policies) -> {
+               policies.properties.put(key, value);

Review comment:
       What if I want to remove this key?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org