You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/27 19:06:26 UTC
[GitHub] [incubator-nuttx] acassis commented on pull request #4908: add board files to support mcuboot
acassis commented on pull request #4908:
URL: https://github.com/apache/incubator-nuttx/pull/4908#issuecomment-980786317
Hi @tito97sp please fix these small issues:
```
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot_image.c:2:1: error: Relative file path does not match actual file
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot_image.c:106:2: error: C++ style comment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot_image.c:110:2: error: C++ style comment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot_image.c:111:0: error: TABs found. First detected
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot_image.c:112:1: error: Right brace must be followed by a blank line
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot_image.c:168:0: error: Garbage follows right bracket
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_bringup.c:329:4: error: Bad alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_bringup.c:330:6: error: Bad left brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_bringup.c:331:79: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_bringup.c:333:6: error: Bad right brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:2:1: error: Relative file path does not match actual file
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:119:1: error: Too many blank lines
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:147:2: error: C++ style comment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:148:2: error: C++ style comment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:157:2: error: Bad left brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:159:2: error: Bad right brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:189:2: error: Bad left brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:195:6: error: Bad left brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:198:6: error: Bad right brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:205:6: error: Bad left brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:208:6: error: Bad right brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:210:2: error: Bad right brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:216:1: error: Too many blank lines
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:232:1: error: Too many blank lines
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:233:27: error: C++ style comment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:233:35: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:233:43: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:233:80: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:239:2: error: Bad left brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:240:4: error: Bad alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:241:2: error: Bad right brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:246:2: error: Bad left brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:247:4: error: Bad alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:248:2: error: Bad right brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:254:2: error: Bad left brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:257:4: error: Bad alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:258:2: error: Bad right brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:273:2: error: Bad left brace alignment
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/stm32h7/nucleo-h743zi/src/stm32_progmem.c:277:2: error: Bad right brace alignment
```
You can run nxstyle/checkpatch to confirm everything is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org