You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/02/21 06:55:44 UTC
[kudu-CR] [mini-cluster] fixed typos in WaitForReplicaCount()
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6090
Change subject: [mini-cluster] fixed typos in WaitForReplicaCount()
......................................................................
[mini-cluster] fixed typos in WaitForReplicaCount()
Fixed a couple of typos in ExternalMiniClusterFsInspector:
in implementation of WaitForReplicaCount() there was an extra call to
CountReplicasInMetadataDirs() and a typo in error message fmt string.
Change-Id: I4eef3e220fb3e330a8d7d29eb56adea1aab64ab0
---
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/6090/1
--
To view, visit http://gerrit.cloudera.org:8080/6090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4eef3e220fb3e330a8d7d29eb56adea1aab64ab0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini-cluster] fixed typos in WaitForReplicaCount()
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: [mini-cluster] fixed typos in WaitForReplicaCount()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4eef3e220fb3e330a8d7d29eb56adea1aab64ab0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini-cluster] fixed typos in WaitForReplicaCount()
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: [mini-cluster] fixed typos in WaitForReplicaCount()
......................................................................
[mini-cluster] fixed typos in WaitForReplicaCount()
Fixed a couple of typos in ExternalMiniClusterFsInspector:
in implementation of WaitForReplicaCount() there was an extra call to
CountReplicasInMetadataDirs() and a typo in error message fmt string.
Change-Id: I4eef3e220fb3e330a8d7d29eb56adea1aab64ab0
Reviewed-on: http://gerrit.cloudera.org:8080/6090
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4eef3e220fb3e330a8d7d29eb56adea1aab64ab0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [mini-cluster] fixed typos in WaitForReplicaCount()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [mini-cluster] fixed typos in WaitForReplicaCount()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4eef3e220fb3e330a8d7d29eb56adea1aab64ab0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No