[jira] [Reopened] (SLING-4630) Avoid logging an failure that is thrown as exception in ModelFactory.createModel

["Stefan Seifert (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Seifert reopened SLING-4630:
-----------------------------------

> Avoid logging an failure that is thrown as exception in ModelFactory.createModel
> --------------------------------------------------------------------------------
>
>                 Key: SLING-4630
>                 URL: https://issues.apache.org/jira/browse/SLING-4630
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: Sling Models Implementation 1.1.0
>            Reporter: Georg Henzler
>            Assignee: Stefan Seifert
>            Priority: Minor
>             Fix For: Sling Models Impl 1.2.0
>
>         Attachments: SLING-4630-patch1.patch, SLING-4630-patch2.patch
>
>
> If a post construct method throws an exception, that is NOT a technical problem but can be fixed by the user (e.g. some content problem that can be fixed by an author directly), at the moment this is still logged as an error in the log file (where it should really a debug log at most).  
> We could disable the error log for post construct messages completely (patch1, solves the problem for ModelAdapterFactory.createModel() but for  ModelAdapterFactory.getAdapter() this would swallow the exception, also see SLING-3709) or we just ensure, that for the case we throw the exception we don't *throw and log* the exception (which is bad practice anyway, patch2). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)