You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/06/19 04:50:21 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #2908: Check
disallowed imports in agent instrumentation classes
kezhenxu94 opened a new pull request #2908: Check disallowed imports in agent instrumentation classes
URL: https://github.com/apache/skywalking/pull/2908
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- [x] Enhancement
- Related issues
As described in #2871 , we merged a PR that breaks the agent by importing external classes, and a script to check that is provided in #2881 , here I'm proposing another way to check this before our contributors commit and push their codes, by leveraging the checkstyle plugin, if the contributors have a checkstyle plugin installed in their IDE, it would show an error when writing codes, before submitting, which would save some time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services