You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by jondong <gi...@git.apache.org> on 2018/06/26 06:52:57 UTC
[GitHub] incubator-weex pull request #1290: [Release] Fixed the weex_core build path ...
GitHub user jondong opened a pull request:
https://github.com/apache/incubator-weex/pull/1290
[Release] Fixed the weex_core build path issue
As we shrink the path 'android/sdk' to 'android_sdk' when
generating release source package, the relative path dependency
in 'android/sdk/build.gradle' for weex_core has been broken. Fixed
this issue using sed.
Also fixed the replacement issues with find.
Granted the execution rights to 'scripts/build_from_source.sh'.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jondong/incubator-weex generate-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1290
----
commit 593797edc1a47f4af73f122812195a1939283e2c
Author: Jonathan Dong <jo...@...>
Date: 2018-06-26T06:43:50Z
[Release] Fixed the weex_core build path issue
As we shrink the path 'android/sdk' to 'android_sdk' when
generating release source package, the relative path dependency
in 'android/sdk/build.gradle' for weex_core has been broken. Fixed
this issue using sed.
Also fixed the replacement issues with find.
Granted the execution rights to 'scripts/build_from_source.sh'.
----
---
[GitHub] incubator-weex pull request #1290: [Release] Fixed the weex_core build path ...
Posted by jondong <gi...@git.apache.org>.
Github user jondong closed the pull request at:
https://github.com/apache/incubator-weex/pull/1290
---
[GitHub] incubator-weex issue #1290: [Release] Fixed the weex_core build path issue
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1290
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex issue #1290: [Release] Fixed the weex_core build path issue
Posted by jondong <gi...@git.apache.org>.
Github user jondong commented on the issue:
https://github.com/apache/incubator-weex/pull/1290
@cxfeng1 PTAL, thanks.
---
[GitHub] incubator-weex pull request #1290: [Release] Fixed the weex_core build path ...
Posted by jondong <gi...@git.apache.org>.
GitHub user jondong reopened a pull request:
https://github.com/apache/incubator-weex/pull/1290
[Release] Fixed the weex_core build path issue
As we shrink the path 'android/sdk' to 'android_sdk' when
generating release source package, the relative path dependency
in 'android/sdk/build.gradle' for weex_core has been broken. Fixed
this issue using sed.
Also fixed the replacement issues with find.
Granted the execution rights to 'scripts/build_from_source.sh'.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jondong/incubator-weex generate-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1290
----
commit e82a37236ce8eeffe49f1bbacc20cbeec70bcd43
Author: Jonathan Dong <jo...@...>
Date: 2018-06-26T06:43:50Z
[Release] Fixed the weex_core build path issue
As we shrink the path 'android/sdk' to 'android_sdk' when
generating release source package, the relative path dependency
in 'android/sdk/build.gradle' for weex_core has been broken. Fixed
this issue using sed.
Same thing happens to the path of 'pre-build', fixed the build.gradle
and XCode project file with sed, and added pre-build into the release
rules to make iOS build pass.
Also fixed the replacement issues with find command, and added iOS
replacement support as well.
Granted the execution rights to 'scripts/build_from_source.sh'.
----
---
[GitHub] incubator-weex issue #1290: [Release] Fixed the weex_core build path issue
Posted by jondong <gi...@git.apache.org>.
Github user jondong commented on the issue:
https://github.com/apache/incubator-weex/pull/1290
merged, close PR.
---
[GitHub] incubator-weex pull request #1290: [Release] Fixed the weex_core build path ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/1290
---