You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/29 20:18:37 UTC

[GitHub] [beam] lukecwik commented on a diff in pull request #24388: Update grouping table to sample window size as well

lukecwik commented on code in PR #24388:
URL: https://github.com/apache/beam/pull/24388#discussion_r1035238519


##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/PrecombineGroupingTable.java:
##########
@@ -189,16 +184,10 @@ <K> WindowedGroupingTableKey(
         K key,
         Collection<? extends BoundedWindow> windows,
         Coder<K> keyCoder,
-        SizeEstimator<K> keySizer) {
+        SizeEstimator sizer) {

Review Comment:
   Caches::weigh doesn't care about type. It relies on Jamm which uses java's instrumentation API to measure the size of the object in memory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org