[GitHub] [geode] bschuchardt opened pull request #4073: GEODE-7219 BufferUnderflowException in PutReplyMessage deserialization

["bschuchardt (GitHub)" <gi...@apache.org>]

VersionTag serialization was being affected by concurrent modification
of its memberId/previousMemberId fields, causing the HAS_PREVIOUS_MEMBER_ID
flag bit to be set and the DUPLICATE_MEMBER_IDS flag to _not_ be set.
It then went on to perform the same checks later in toData() and make
different decisions, winding up by not serializing the previousMemberId
field because it was then == to the memberId field.

1) decide on what the flags are going to be in toData and do not perform
the same calculations again.

2) use equals() when seeing if memberId and previousMemberId are equal.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4073 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on issue #4073: GEODE-7219 BufferUnderflowException in PutReplyMessage deserialization

["Bill (GitHub)" <gi...@apache.org>]

Looks good now @bschuchardt 

[ Full content available at: https://github.com/apache/geode/pull/4073 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on pull request #4073: GEODE-7219 BufferUnderflowException in PutReplyMessage deserialization

["Bill (GitHub)" <gi...@apache.org>]

I'm curious why you chose to introduce a new variable rather than referencing the `HAS_PREVIOUS_MEMBER_ID` and `DUPLICATE_MEMBER_IDS` bits in `flags`?

[ Full content available at: https://github.com/apache/geode/pull/4073 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on pull request #4073: GEODE-7219 BufferUnderflowException in PutReplyMessage deserialization

["bschuchardt (GitHub)" <gi...@apache.org>]

That bit is complicated by the other change I made - to use Objects.equals() instead of "==" for equality checks.

[ Full content available at: https://github.com/apache/geode/pull/4073 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on pull request #4073: GEODE-7219 BufferUnderflowException in PutReplyMessage deserialization

["Bill (GitHub)" <gi...@apache.org>]

With changes reverted I see one test failing: `testBufferUnderflowFromOldVersionIsIgnored()`. It fails with `BufferUnderflowException` ✓

[ Full content available at: https://github.com/apache/geode/pull/4073 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on pull request #4073: GEODE-7219 BufferUnderflowException in PutReplyMessage deserialization

["Bill (GitHub)" <gi...@apache.org>]

I'm curious why you chose to introduce a new variable rather than referencing the `DUPLICATE_MEMBER_IDS` bit in `flags`?

[ Full content available at: https://github.com/apache/geode/pull/4073 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org