[PATCH] fix for unclear error message "Can't find a temporary directory"

[Hendy Irawan <he...@rainbowpurple.com>]

I added an explanation where this usually (99% of the time? at least 
according to Google) means the repository runs out of disk space.

Please accept this patch.

Thank you.

Re: [PATCH] fix for unclear error message "Can't find a temporary directory"

[Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>]

2008-01-27 18:41:57 Hendy Irawan napisał(a):
> I added an explanation where this usually (99% of the time? at least 
> according to Google) means the repository runs out of disk space.
> 
> Please accept this patch.

You shouldn't change anything in .po files!
This patch would leave broken msgstrs.

-- 
Arfrever Frehtes Taifersar Arahesis

Re: [PATCH] fix for unclear error message "Can't find a temporary directory"

[Erik Huelsmann <eh...@gmail.com>]

On Jan 31, 2008 10:59 PM, Hyrum K. Wright <hy...@mail.utexas.edu> wrote:
>
> Hendy Irawan wrote:
> > I added an explanation where this usually (99% of the time? at least
> > according to Google) means the repository runs out of disk space.
> >
> > Please accept this patch.
>
> I've reproduced your patch below.
> There could be other reasons for being unable to find a temporary
> directory, with being out of disk space only one of them.  The directory
> may not exist, it may not be writable by the user, or Subversion could
> be prohibited from writing there by other means (eg, SELinux).  I
> hesitant to give more information in this error message, for fear of
> leading other users astray.

The correct error message would be "Unable to find a writeable
temporary directory, or not enough space to create probing file on
destination filesystem."

I'm not sure that really helps any users, but it's actually what's happening.


HTH,

Erik.

>
> -Hyrum
>
> index dd29b82..fcc4fdd 100644
> --- a/subversion/libsvn_subr/io.c
> +++ b/subversion/libsvn_subr/io.c
> @@ -645,7 +645,7 @@ svn_io_temp_dir(const char **dir,
>    apr_status_t apr_err = apr_temp_dir_get(dir, pool);
>
>    if (apr_err)
> -    return svn_error_wrap_apr(apr_err, _("Can't find a temporary
> directory"));
> +    return svn_error_wrap_apr(apr_err, _("Can't find a temporary
> directory (repository probably runs out of disk space)"));
>
>    *dir = svn_path_canonicalize(*dir, pool);
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] fix for unclear error message "Can't find a temporary directory"

["Hyrum K. Wright" <hy...@mail.utexas.edu>]

Hendy Irawan wrote:
> I added an explanation where this usually (99% of the time? at least
> according to Google) means the repository runs out of disk space.
> 
> Please accept this patch.

I've reproduced your patch below.
There could be other reasons for being unable to find a temporary
directory, with being out of disk space only one of them.  The directory
may not exist, it may not be writable by the user, or Subversion could
be prohibited from writing there by other means (eg, SELinux).  I
hesitant to give more information in this error message, for fear of
leading other users astray.

-Hyrum

index dd29b82..fcc4fdd 100644
--- a/subversion/libsvn_subr/io.c
+++ b/subversion/libsvn_subr/io.c
@@ -645,7 +645,7 @@ svn_io_temp_dir(const char **dir,
   apr_status_t apr_err = apr_temp_dir_get(dir, pool);

   if (apr_err)
-    return svn_error_wrap_apr(apr_err, _("Can't find a temporary
directory"));
+    return svn_error_wrap_apr(apr_err, _("Can't find a temporary
directory (repository probably runs out of disk space)"));

   *dir = svn_path_canonicalize(*dir, pool);