You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Jingsong Lee (JIRA)" <ji...@apache.org> on 2017/03/23 11:15:41 UTC

[jira] [Commented] (BEAM-1772) Support merging WindowFn other than IntervalWindow on Flink Runner

    [ https://issues.apache.org/jira/browse/BEAM-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938119#comment-15938119 ] 

Jingsong Lee commented on BEAM-1772:
------------------------------------

The problem is that {{FlinkMergingPartialReduceFunction}}/{{FlinkMergingReduceFunction}}/{{FlinkMergingNonShuffleReduceFunction}} merge window with SortedList<WindowedValue> to produce new WindowedValue of merged window. This behavior is different from {{WindowFn.mergeWindows (MergeContext)}}, Now we cast BoundedWindow to IntervalWindow. What the {{ReduceFnRunner}} would do is implemented here but without any regard for triggers.
I think we can use {{GroupAlsoByWindowViaOutputBufferDoFn}} instead. [~aljoscha] What do you think?

> Support merging WindowFn other than IntervalWindow on Flink Runner
> ------------------------------------------------------------------
>
>                 Key: BEAM-1772
>                 URL: https://issues.apache.org/jira/browse/BEAM-1772
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Ismaël Mejía
>            Assignee: Aljoscha Krettek
>
> Flink currently supports merging IntervalWindows, however if you have a WindowFn who extends IntervalWindow the execution breaks.
> I found this while executing a Pipeline in Flink's batch mode.
> This will involve probably changing the window merging logic in `FlinkMergingReduceFunction.mergeWindows()` and other similar parts to really use the merging logic of the `WindowFn`.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)