[GitHub] [maven-doxia] elharo commented on a diff in pull request #149: Prefer Apache commons IO to codehaus

["elharo (via GitHub)" <gi...@apache.org>]

elharo commented on code in PR #149:
URL: https://github.com/apache/maven-doxia/pull/149#discussion_r1121726597


##########
doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc/XdocParser.java:
##########
@@ -333,7 +330,7 @@ private void handleMetaStart(XmlPullParser parser, Sink sink, SinkEventAttribute
 
     private void handleParamStart(XmlPullParser parser, Sink sink) throws MacroExecutionException {
         if (!isSecondParsing()) {
-            if (StringUtils.isNotEmpty(macroName)) {
+            if (macroName != null && !macroName.isEmpty()) {
                 String paramName = parser.getAttributeValue(null, Attribute.NAME.toString());

Review Comment:
   Because JDK methods are preferred over StringUtils.isEmpty. There are also calls to StringUtils.join which is not as easily replaced by JDK 8 methods



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org