You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Thiago Veronezi <th...@veronezi.org> on 2012/02/16 16:23:15 UTC
TOMEE-130 - new code
Guys,
I am working on the
TOMEE-130<https://issues.apache.org/jira/browse/TOMEE-130> task.
Please code review the java code I implemented for this new interface.
The intent of JndiWs is to provide a json string with all lookup string one
can access. Is that a good approach?
Thanks,
Thiago.
Re: TOMEE-130 - new code
Posted by Thiago Veronezi <th...@veronezi.org>.
>> Of course I made the mistake of trying it in tomee-webprofile where it
will not work :)
>>JAX-RS is going to be added to the Web Profile in Java EE 7, so it should
work itself out eventually.
>>Unrelated note, we might try and find a way to strip down the JAX-RS
support so we can include it in TomEE Web Profile without increasing the
footprint too much.
Hi David,
Thanks for the warning. I will use a regular servlet to generate the json
strings.
[]s,
Thiago.
On Sun, Feb 19, 2012 at 6:35 PM, David Blevins <da...@gmail.com>wrote:
> It's looking pretty great so far!!
>
> Of course I made the mistake of trying it in tomee-webprofile where it
> will not work :) JAX-RS is going to be added to the Web Profile in Java EE
> 7, so it should work itself out eventually. Unrelated note, we might try
> and find a way to strip down the JAX-RS support so we can include it in
> TomEE Web Profile without increasing the footprint too much.
>
> Feature requests I would have might be:
>
> - Show ContainerInfo data
> - Show ResourceInfo data
> - Show AppInfo data
>
>
> -David
>
> On Feb 16, 2012, at 8:14 AM, Thiago Veronezi wrote:
>
> > Nice catch! Thanks Romain!
> >
> > []s,
> > Thiago.
> >
> > On Thu, Feb 16, 2012 at 10:25 AM, Romain Manni-Bucau
> > <rm...@gmail.com>wrote:
> >
> >> I like the cod you added (in particular the js ;))
> >>
> >> The only warning i have about JAXRS is we should just check our
> context.xml
> >> to prevent access from something else than localhost is still working
> with
> >> it otherwise it can be a big security issue.
> >>
> >> But good job Thiago!
> >>
> >> - Romain
> >>
> >>
> >> 2012/2/16 Thiago Veronezi <th...@veronezi.org>
> >>
> >>> Guys,
> >>>
> >>> I am working on the
> >>> TOMEE-130<https://issues.apache.org/jira/browse/TOMEE-130> task.
> >>> Please code review the java code I implemented for this new interface.
> >>> The intent of JndiWs is to provide a json string with all lookup string
> >> one
> >>> can access. Is that a good approach?
> >>>
> >>> Thanks,
> >>> Thiago.
> >>>
> >>
>
>
Re: TOMEE-130 - new code
Posted by David Blevins <da...@gmail.com>.
It's looking pretty great so far!!
Of course I made the mistake of trying it in tomee-webprofile where it will not work :) JAX-RS is going to be added to the Web Profile in Java EE 7, so it should work itself out eventually. Unrelated note, we might try and find a way to strip down the JAX-RS support so we can include it in TomEE Web Profile without increasing the footprint too much.
Feature requests I would have might be:
- Show ContainerInfo data
- Show ResourceInfo data
- Show AppInfo data
-David
On Feb 16, 2012, at 8:14 AM, Thiago Veronezi wrote:
> Nice catch! Thanks Romain!
>
> []s,
> Thiago.
>
> On Thu, Feb 16, 2012 at 10:25 AM, Romain Manni-Bucau
> <rm...@gmail.com>wrote:
>
>> I like the cod you added (in particular the js ;))
>>
>> The only warning i have about JAXRS is we should just check our context.xml
>> to prevent access from something else than localhost is still working with
>> it otherwise it can be a big security issue.
>>
>> But good job Thiago!
>>
>> - Romain
>>
>>
>> 2012/2/16 Thiago Veronezi <th...@veronezi.org>
>>
>>> Guys,
>>>
>>> I am working on the
>>> TOMEE-130<https://issues.apache.org/jira/browse/TOMEE-130> task.
>>> Please code review the java code I implemented for this new interface.
>>> The intent of JndiWs is to provide a json string with all lookup string
>> one
>>> can access. Is that a good approach?
>>>
>>> Thanks,
>>> Thiago.
>>>
>>
Re: TOMEE-130 - new code
Posted by Thiago Veronezi <th...@veronezi.org>.
Nice catch! Thanks Romain!
[]s,
Thiago.
On Thu, Feb 16, 2012 at 10:25 AM, Romain Manni-Bucau
<rm...@gmail.com>wrote:
> I like the cod you added (in particular the js ;))
>
> The only warning i have about JAXRS is we should just check our context.xml
> to prevent access from something else than localhost is still working with
> it otherwise it can be a big security issue.
>
> But good job Thiago!
>
> - Romain
>
>
> 2012/2/16 Thiago Veronezi <th...@veronezi.org>
>
> > Guys,
> >
> > I am working on the
> > TOMEE-130<https://issues.apache.org/jira/browse/TOMEE-130> task.
> > Please code review the java code I implemented for this new interface.
> > The intent of JndiWs is to provide a json string with all lookup string
> one
> > can access. Is that a good approach?
> >
> > Thanks,
> > Thiago.
> >
>
Re: TOMEE-130 - new code
Posted by Romain Manni-Bucau <rm...@gmail.com>.
I like the cod you added (in particular the js ;))
The only warning i have about JAXRS is we should just check our context.xml
to prevent access from something else than localhost is still working with
it otherwise it can be a big security issue.
But good job Thiago!
- Romain
2012/2/16 Thiago Veronezi <th...@veronezi.org>
> Guys,
>
> I am working on the
> TOMEE-130<https://issues.apache.org/jira/browse/TOMEE-130> task.
> Please code review the java code I implemented for this new interface.
> The intent of JndiWs is to provide a json string with all lookup string one
> can access. Is that a good approach?
>
> Thanks,
> Thiago.
>