You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by so...@apache.org on 2013/10/23 03:35:20 UTC
git commit: TS-2291: Disable remap_stats plugin compile on platforms
that do not have a reentrant hsearch implementation
Updated Branches:
refs/heads/master e265ff890 -> a2809d187
TS-2291: Disable remap_stats plugin compile on platforms that do
not have a reentrant hsearch implementation
This means this plugin will not build on FreeBSD or OmniOS.
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a2809d18
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a2809d18
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a2809d18
Branch: refs/heads/master
Commit: a2809d1874ea69a78e44e2fdf916217db1d37100
Parents: e265ff8
Author: Phil Sorber <so...@apache.org>
Authored: Tue Oct 22 19:30:06 2013 -0600
Committer: Phil Sorber <so...@apache.org>
Committed: Tue Oct 22 19:31:58 2013 -0600
----------------------------------------------------------------------
configure.ac | 8 ++++++++
plugins/experimental/remap_stats/Makefile.am | 4 ++++
2 files changed, 12 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a2809d18/configure.ac
----------------------------------------------------------------------
diff --git a/configure.ac b/configure.ac
index 439a6e1..bb23933 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1786,6 +1786,14 @@ AC_CHECK_TYPE([struct tcp_info],
)
AM_CONDITIONAL([BUILD_TCPINFO_PLUGIN], [ test "x${enable_tcpinfo_plugin}" != "xno" ])
+AC_SEARCH_LIBS([hcreate_r],
+ [],
+ [enable_remap_stats_plugin=yes],
+ [enable_remap_stats_plugin=no],
+ []
+)
+AM_CONDITIONAL([BUILD_REMAP_STATS_PLUGIN], [ test "x${enable_remap_stats_plugin}" != "xno" ])
+
#
# use modular IOCORE
#
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a2809d18/plugins/experimental/remap_stats/Makefile.am
----------------------------------------------------------------------
diff --git a/plugins/experimental/remap_stats/Makefile.am b/plugins/experimental/remap_stats/Makefile.am
index 4033fa4..a817bb8 100644
--- a/plugins/experimental/remap_stats/Makefile.am
+++ b/plugins/experimental/remap_stats/Makefile.am
@@ -16,6 +16,10 @@
include $(top_srcdir)/build/plugins.mk
+if BUILD_REMAP_STATS_PLUGIN
+
pkglib_LTLIBRARIES = remap_stats.la
remap_stats_la_SOURCES = remap_stats.c
remap_stats_la_LDFLAGS = $(TS_PLUGIN_LDFLAGS)
+
+endif
Re: git commit: TS-2291: Disable remap_stats plugin compile on platforms that do not have a reentrant hsearch implementation
Posted by James Peach <jp...@apache.org>.
On Oct 22, 2013, at 6:35 PM, sorber@apache.org wrote:
> Updated Branches:
> refs/heads/master e265ff890 -> a2809d187
>
>
> TS-2291: Disable remap_stats plugin compile on platforms that do
> not have a reentrant hsearch implementation
Nice! It would be good form to also do an AC_HEADERS check for search.h.
>
> This means this plugin will not build on FreeBSD or OmniOS.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a2809d18
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a2809d18
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a2809d18
>
> Branch: refs/heads/master
> Commit: a2809d1874ea69a78e44e2fdf916217db1d37100
> Parents: e265ff8
> Author: Phil Sorber <so...@apache.org>
> Authored: Tue Oct 22 19:30:06 2013 -0600
> Committer: Phil Sorber <so...@apache.org>
> Committed: Tue Oct 22 19:31:58 2013 -0600
>
> ----------------------------------------------------------------------
> configure.ac | 8 ++++++++
> plugins/experimental/remap_stats/Makefile.am | 4 ++++
> 2 files changed, 12 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a2809d18/configure.ac
> ----------------------------------------------------------------------
> diff --git a/configure.ac b/configure.ac
> index 439a6e1..bb23933 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1786,6 +1786,14 @@ AC_CHECK_TYPE([struct tcp_info],
> )
> AM_CONDITIONAL([BUILD_TCPINFO_PLUGIN], [ test "x${enable_tcpinfo_plugin}" != "xno" ])
>
> +AC_SEARCH_LIBS([hcreate_r],
> + [],
> + [enable_remap_stats_plugin=yes],
> + [enable_remap_stats_plugin=no],
> + []
> +)
> +AM_CONDITIONAL([BUILD_REMAP_STATS_PLUGIN], [ test "x${enable_remap_stats_plugin}" != "xno" ])
> +
> #
> # use modular IOCORE
> #
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a2809d18/plugins/experimental/remap_stats/Makefile.am
> ----------------------------------------------------------------------
> diff --git a/plugins/experimental/remap_stats/Makefile.am b/plugins/experimental/remap_stats/Makefile.am
> index 4033fa4..a817bb8 100644
> --- a/plugins/experimental/remap_stats/Makefile.am
> +++ b/plugins/experimental/remap_stats/Makefile.am
> @@ -16,6 +16,10 @@
>
> include $(top_srcdir)/build/plugins.mk
>
> +if BUILD_REMAP_STATS_PLUGIN
> +
> pkglib_LTLIBRARIES = remap_stats.la
> remap_stats_la_SOURCES = remap_stats.c
> remap_stats_la_LDFLAGS = $(TS_PLUGIN_LDFLAGS)
> +
> +endif
>
Re: git commit: TS-2291: Disable remap_stats plugin compile on platforms that do not have a reentrant hsearch implementation
Posted by James Peach <jp...@apache.org>.
On Oct 22, 2013, at 6:35 PM, sorber@apache.org wrote:
> Updated Branches:
> refs/heads/master e265ff890 -> a2809d187
>
>
> TS-2291: Disable remap_stats plugin compile on platforms that do
> not have a reentrant hsearch implementation
Nice! It would be good form to also do an AC_HEADERS check for search.h.
>
> This means this plugin will not build on FreeBSD or OmniOS.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a2809d18
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a2809d18
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a2809d18
>
> Branch: refs/heads/master
> Commit: a2809d1874ea69a78e44e2fdf916217db1d37100
> Parents: e265ff8
> Author: Phil Sorber <so...@apache.org>
> Authored: Tue Oct 22 19:30:06 2013 -0600
> Committer: Phil Sorber <so...@apache.org>
> Committed: Tue Oct 22 19:31:58 2013 -0600
>
> ----------------------------------------------------------------------
> configure.ac | 8 ++++++++
> plugins/experimental/remap_stats/Makefile.am | 4 ++++
> 2 files changed, 12 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a2809d18/configure.ac
> ----------------------------------------------------------------------
> diff --git a/configure.ac b/configure.ac
> index 439a6e1..bb23933 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1786,6 +1786,14 @@ AC_CHECK_TYPE([struct tcp_info],
> )
> AM_CONDITIONAL([BUILD_TCPINFO_PLUGIN], [ test "x${enable_tcpinfo_plugin}" != "xno" ])
>
> +AC_SEARCH_LIBS([hcreate_r],
> + [],
> + [enable_remap_stats_plugin=yes],
> + [enable_remap_stats_plugin=no],
> + []
> +)
> +AM_CONDITIONAL([BUILD_REMAP_STATS_PLUGIN], [ test "x${enable_remap_stats_plugin}" != "xno" ])
> +
> #
> # use modular IOCORE
> #
>
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a2809d18/plugins/experimental/remap_stats/Makefile.am
> ----------------------------------------------------------------------
> diff --git a/plugins/experimental/remap_stats/Makefile.am b/plugins/experimental/remap_stats/Makefile.am
> index 4033fa4..a817bb8 100644
> --- a/plugins/experimental/remap_stats/Makefile.am
> +++ b/plugins/experimental/remap_stats/Makefile.am
> @@ -16,6 +16,10 @@
>
> include $(top_srcdir)/build/plugins.mk
>
> +if BUILD_REMAP_STATS_PLUGIN
> +
> pkglib_LTLIBRARIES = remap_stats.la
> remap_stats_la_SOURCES = remap_stats.c
> remap_stats_la_LDFLAGS = $(TS_PLUGIN_LDFLAGS)
> +
> +endif
>