You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/02/03 19:32:18 UTC
[GitHub] [cassandra-accord] bdeggleston commented on a change in pull request #1: Topology change
bdeggleston commented on a change in pull request #1:
URL: https://github.com/apache/cassandra-accord/pull/1#discussion_r798902740
##########
File path: accord-core/src/test/java/accord/burn/BurnTest.java
##########
@@ -103,40 +108,27 @@ static void burn(TopologyFactory topologyFactory, List<Id> clients, List<Id> nod
}
static void burn(long seed, TopologyFactory topologyFactory, List<Id> clients, List<Id> nodes, int keyCount, int operations, int concurrency) throws IOException
- {
- burn(seed, topologyFactory, clients, nodes, keyCount, operations, concurrency, System.out, System.err);
- }
-
- static void burn(long seed, TopologyFactory topologyFactory, List<Id> clients, List<Id> nodes, int keyCount, int operations, int concurrency, PrintStream out, PrintStream err) throws IOException
{
Random random = new Random();
System.out.println(seed);
random.setSeed(seed);
- burn(random, topologyFactory, clients, nodes, keyCount, operations, concurrency, out, err);
- }
-
- static void burn(Random random, TopologyFactory topologyFactory, List<Id> clients, List<Id> nodes, int keyCount, int operations, int concurrency)
- {
- burn(random, topologyFactory, clients, nodes, keyCount, operations, concurrency, System.out, System.err);
+ burn(random, topologyFactory, clients, nodes, keyCount, operations, concurrency);
}
static void reconcile(long seed, TopologyFactory topologyFactory, List<Id> clients, List<Id> nodes, int keyCount, int operations, int concurrency) throws IOException, ExecutionException, InterruptedException, TimeoutException
{
- ReconcilingOutputStreams streams = new ReconcilingOutputStreams(System.out, System.err, 2);
Review comment:
yes it was removed when I added logging. Looking closer, it appears to be comparing the output of 2 identical runs in the reconcile method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org