You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/13 09:19:06 UTC

[GitHub] [flink] victorunique commented on a change in pull request #17419: [FLINK-24460][rocksdb] Rocksdb Iterator Error Handling Improvement

victorunique commented on a change in pull request #17419:
URL: https://github.com/apache/flink/pull/17419#discussion_r727866415



##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksIteratorWrapper.java
##########
@@ -111,7 +114,6 @@ public void status() {
     @Override
     public void refresh() throws RocksDBException {
         iterator.refresh();
-        status();

Review comment:
       Thanks for your feedback. Can you please elaborate on why we need to leave status() in this refresh() method? Is that due to the comment in the RocksIteratorInterface ("_If supported, renew the iterator to represent the latest state. The iterator will be invalidated after the call._")?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org