You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (JIRA)" <ji...@apache.org> on 2015/05/03 18:37:06 UTC

[jira] [Resolved] (MSKINS-92) Facebook Like iframe too narrow when in topbar

     [ https://issues.apache.org/jira/browse/MSKINS-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Osipov resolved MSKINS-92.
----------------------------------
       Resolution: Fixed
    Fix Version/s: fluido-1.4

Francesco, I have chosen *not* to provide a parameter for the widget but rather committed a new static value. I will explain why I did this:

Adding a parameter for this will ultimately lead to: please add a parameter for widget X too. This isn't right. And still, it would't work right because the JS code renders according to your {{Accept-Language}} header and you *cannot* set this right at configure time. The code should render appropriately. A better solution is to integrate all of those widgets with a plugin as layed out [here|https://issues.apache.org/jira/browse/MSKINS-92?focusedCommentId=14452624&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14452624] already.

> Facebook Like iframe too narrow when in topbar
> ----------------------------------------------
>
>                 Key: MSKINS-92
>                 URL: https://issues.apache.org/jira/browse/MSKINS-92
>             Project: Maven Skins
>          Issue Type: Bug
>          Components: Fluido Skin
>            Reporter: Francesco Chicchiriccò
>            Assignee: Michael Osipov
>            Priority: Minor
>             Fix For: fluido-1.4
>
>         Attachments: MSKINS-92.patch, badges.png
>
>
> See Apache Syncope website at http://syncope.apache.org
> On the top right you can see the Facebook Like button rendered by
> {code}
>     <iframe src="http://www.facebook.com/plugins/like.php?href=http://syncope.apache.org/&send=false&layout=button_count&show-faces=false&action=like&colorscheme=dark"
>         scrolling="no" frameborder="0"
>         style="border:none; width:80px; height:20px; margin-top: 10px;"  class="pull-right" ></iframe>
> {code}
> when changing style to 
> {code}
> "border:none; width:100px; height:20px; margin-top: 10px;"
> {code}
> the right-side box is rendered correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)