You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "thswlsqls (via GitHub) via notifications" <no...@shardingsphere.apache.org> on 2026/10/31 05:21:56 UTC

[PR] Fix Javadoc wording in ShardingSpherePreconditions [shardingsphere]

thswlsqls opened a new pull request, #40428:
URL: https://github.com/apache/shardingsphere/pull/40428

   
   No issue: typo fix.
   
   Changes proposed in this pull request:
     - Describe the `Map` overload of `checkNotEmpty` as checking a map instead of a collection, matching its `@param map`.
     - Replace the ungrammatical "must empty" with "is empty" in both `checkMustEmpty` overloads, mirroring the "is not empty" wording of `checkNotEmpty`.
     - Javadoc only; no behavior change, so no tests or release note entry.
   
   AI assistance: Claude Code was used to draft the Javadoc change in `infra/exception/.../ShardingSpherePreconditions.java`. I reviewed, verified, and take responsibility for every line submitted.
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   - [x] I have disclosed the tool and affected files or scope for any material AI assistance, as required by the [AI-assisted contribution policy].
   
   [AI-assisted contribution policy]: https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Javadoc wording in ShardingSpherePreconditions [shardingsphere]

Posted by "terrymanu (via GitHub) via notifications" <no...@shardingsphere.apache.org>.
terrymanu merged PR #40428:
URL: https://github.com/apache/shardingsphere/pull/40428


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org